apply suggestions from reviewer

SeleniumHQ · Sep 30, 2024 · 51d082a · 51d082a
1 parent e725eeb
commit 51d082a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 32 deletions.
diff --git a/rust/src/lib.rs b/rust/src/lib.rs
@@ -487,19 +487,6 @@ pub trait SeleniumManager {
                             discovered_major_browser_version,
                             major_browser_version,
                         ));
-                        if self
-                            .request_fixed_browser_version_from_online(
-                                major_browser_version.as_str(),
-                            )
-                            .is_err()
-                        {
-                            self.set_fallback_driver_from_cache(false);
-                            return Err(anyhow!(format!(
-                                "Invalid {} version provided: {}",
-                                self.get_browser_name(),
-                                major_browser_version
-                            )));
-                        }
                         download_browser = true;
                     } else {
                         self.set_browser_version(discovered_version);
@@ -763,7 +750,10 @@ pub trait SeleniumManager {
         // Download browser if necessary
         match self.download_browser_if_necessary(&original_browser_version) {
             Ok(_) => {}
-            Err(err) => self.check_error_with_driver_in_path(&use_driver_in_path, err)?,
+            Err(err) => {
+                self.set_fallback_driver_from_cache(false);
+                self.check_error_with_driver_in_path(&use_driver_in_path, err)?
+            }
         }
 
         // With the discovered browser version, discover the proper driver version using online endpoints

diff --git a/rust/tests/browser_tests.rs b/rust/tests/browser_tests.rs
@@ -160,21 +160,3 @@ fn invalid_browser_path_test() {
     .code(DATAERR)
     .failure();
 }
-
-#[test]
-fn invalid_browser_version_test() {
-    let mut cmd = get_selenium_manager();
-    cmd.args(["--browser", "chrome", "--browser-version", "bad-version"])
-        .assert()
-        .code(DATAERR)
-        .failure();
-}
-
-#[test]
-fn valid_browser_version_pass_test() {
-    let mut cmd = get_selenium_manager();
-    cmd.args(["--browser", "chrome", "--browser-version", "127"])
-        .assert()
-        .code(0)
-        .success();
-}