Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop support for PHP <= 7.3 #86

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Chris53897
Copy link
Contributor

Maybe it is time to drop support for PHP <= 7.3 ?
Version Stats:
https://packagist.org/packages/seld/jsonlint/php-stats#1

I only changed the tests.

@stof
Copy link
Contributor

stof commented Nov 14, 2023

Composer supports PHP 7.2 and uses that library (this is even why the library was created initially). So bumping the min PHP version to 7.4 looks wrong to me.

@Chris53897
Copy link
Contributor Author

Ok, in this case, maybe it is time to drop support for PHP <= 7.1 ?

@Seldaek
Copy link
Owner

Seldaek commented Dec 18, 2023

Yeah maybe dropping <=7.1 makes sense, but this repo is also so stable that it doesn't cost much to keep supporting older versions IMO..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants