Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code #1438

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Remove deprecated code #1438

merged 1 commit into from
Jul 23, 2024

Conversation

jbrichau
Copy link
Member

Removed the following deprecated code:

  • The class JSJsonParser has been deprecated since Seaside 3.1.0 (it was renamed to WAJsonParser)
  • The method WARenderContext>>callbackAt: has been deprecated since 3.2.0 (use context callbacks at: instead)

Copy link

codecov bot commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.39%. Comparing base (f681d92) to head (69340ee).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1438   +/-   ##
=======================================
  Coverage   49.38%   49.39%           
=======================================
  Files        9080     9078    -2     
  Lines       80133    80126    -7     
=======================================
  Hits        39576    39576           
+ Misses      40557    40550    -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbrichau
Copy link
Member Author

Requires SeasideSt/Parasol#68 to be merged first to drop the reference to the JsJSONParser

@jbrichau jbrichau merged commit 1523181 into master Jul 23, 2024
21 of 28 checks passed
@jbrichau jbrichau deleted the remove-deprecated branch July 23, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant