Skip to content

Commit

Permalink
just some code style corrections
Browse files Browse the repository at this point in the history
  • Loading branch information
@jbrichau
jbrichau committed Jul 23, 2024
1 parent f305106 commit 944f3e1
Show file tree
Hide file tree
Showing 22 changed files with 29 additions and 13 deletions.
1 change: 1 addition & 0 deletions ...easide-WebSocket-Core.package/WAWebSocket.class/instance/initializeWithRequestContext..st
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
initialization
initializeWithRequestContext: aRequestContext

self initialize.
session := aRequestContext session.
1 change: 1 addition & 0 deletions repository/Seaside-WebSocket-Core.package/WAWebSocket.class/instance/isConnected.st
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
testing
isConnected

self subclassResponsibility
1 change: 1 addition & 0 deletions repository/Seaside-WebSocket-Core.package/WAWebSocket.class/instance/onClose..st
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
callbacks
onClose: aBlock

onClose := aBlock
1 change: 1 addition & 0 deletions repository/Seaside-WebSocket-Core.package/WAWebSocket.class/instance/onError..st
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
callbacks
onError: aOneArgumentBlock

onError := aOneArgumentBlock

1 change: 1 addition & 0 deletions repository/Seaside-WebSocket-Core.package/WAWebSocket.class/instance/onMessage..st
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
callbacks
onMessage: aOneArgumentBlock

onMessage := aOneArgumentBlock
1 change: 1 addition & 0 deletions repository/Seaside-WebSocket-Core.package/WAWebSocket.class/instance/run.st
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
running
run
"Run the WebSocket's input process."

self subclassResponsibility
1 change: 1 addition & 0 deletions repository/Seaside-WebSocket-Core.package/WAWebSocket.class/instance/send..st
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
callbacks
send: aString
"Write data to the socket"

self subclassResponsibility
1 change: 1 addition & 0 deletions repository/Seaside-WebSocket-Core.package/WAWebSocket.class/instance/touchSession.st
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
private
touchSession
"Prevent session expiry."

session ifNotNil: [ :s |
Transcript show:'Touch session ', s key;cr.
s application cache at: s key ifAbsent:[ ] ]
2 changes: 1 addition & 1 deletion repository/Seaside-WebSocket-Core.package/monticello.meta/categories.st
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
SystemOrganization addCategory: #'Seaside-WebSocket-Core'!
self packageOrganizer ensurePackage: #'Seaside-WebSocket-Core' withTags: #()!
2 changes: 1 addition & 1 deletion repository/Seaside-WebSocket-Examples.package/WAWebSocketCounter.class/class/initialize.st
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
initialization
class initialization
initialize
| application |
application := WAAdmin register: self asApplicationAt: 'examples/websockets/counter'.
Expand Down
1 change: 1 addition & 0 deletions repository/Seaside-WebSocket-Examples.package/WAWebSocketCounter.class/instance/decrease.st
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
actions
decrease

self model decrease.
self update: #decrease
1 change: 1 addition & 0 deletions repository/Seaside-WebSocket-Examples.package/WAWebSocketCounter.class/instance/increase.st
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
actions
increase

self model increase.
self update: #increase
1 change: 1 addition & 0 deletions repository/Seaside-WebSocket-Examples.package/WAWebSocketCounter.class/instance/pusher.st
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
accessing
pusher

^ self class pusher
12 changes: 6 additions & 6 deletions .../Seaside-WebSocket-Examples.package/WAWebSocketCounter.class/instance/renderContentOn..st
View file
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
rendering
renderContentOn: html

html heading
id: #count;
with: self model count.

html paragraph: [
html anchor
onClick: (html jQuery ajax
callback: [ self decrease ]);
onClick: (html jQuery ajax callback: [ self decrease ]);
with: 'dec'.
html space; space; space.
html anchor
onClick: (html jQuery ajax
callback: [ self increase ]);
onClick: (html jQuery ajax callback: [ self increase ]);
with: 'inc' ].

html document
addLoadScript: (html websocket
pusher: self pusher)
addLoadScript: (html websocket pusher: self pusher)
3 changes: 2 additions & 1 deletion repository/Seaside-WebSocket-Examples.package/WAWebSocketCounter.class/instance/update..st
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
updating
update: anAspect
"Update the number in all connected web browser. Only the first 3 lines are really needed, the rest adds some eye-candy and can simply be removed if not needed."
"Update the counter in all connected web browsers.
Only the first 3 lines are really needed, the rest adds some eye-candy and can simply be removed if not needed."

self pusher javascript: [ :script |
script << (script jQuery: #count)
Expand Down
2 changes: 1 addition & 1 deletion repository/Seaside-WebSocket-Examples.package/monticello.meta/categories.st
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
SystemOrganization addCategory: #'Seaside-WebSocket-Examples'!
self packageOrganizer ensurePackage: #'Seaside-WebSocket-Examples' withTags: #()!
1 change: 1 addition & 0 deletions repository/Seaside-WebSocket-Zinc.package/WAZincWebSocket.class/instance/initializeWith..st
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
initialization
initializeWith: aZnWebSocket

self initialize.
onClose := [ Transcript show: 'closing...' ].
znWebSocket := aZnWebSocket
1 change: 1 addition & 0 deletions repository/Seaside-WebSocket-Zinc.package/WAZincWebSocket.class/instance/isConnected.st
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
testing
isConnected

^ znWebSocket isConnected
1 change: 1 addition & 0 deletions repository/Seaside-WebSocket-Zinc.package/WAZincWebSocket.class/instance/run.st
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
running
run

[ znWebSocket runWith: [ :message | self touchSession. onMessage value: message ] ]
on: ConnectionClosed
do: [ :e | onClose ifNotNil:[ onClose cull: e ] ]
4 changes: 2 additions & 2 deletions repository/Seaside-WebSocket-Zinc.package/WAZincWebSocket.class/instance/send..st
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
instructions
callbacks
send: aString

self isConnected ifFalse: [ ^ self ].

self touchSession.
znWebSocket sendMessage: aString
2 changes: 1 addition & 1 deletion repository/Seaside-WebSocket-Zinc.package/monticello.meta/categories.st
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
SystemOrganization addCategory: #'Seaside-WebSocket-Zinc'!
self packageOrganizer ensurePackage: #'Seaside-WebSocket-Zinc' withTags: #()!
1 change: 1 addition & 0 deletions ...ry/Seaside-Zinc-Core.package/ZnZincServerAdaptor.class/instance/websocketResponseFrom..st
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
converting
websocketResponseFrom: aRequestContext

| wsdelegate webSocket |
wsdelegate := (ZnSeasideWebSocketDelegate new handler: [ :ws | webSocket ifNotNil:[ :wasocket | wasocket znWebSocket: ws ] ]).
((aRequestContext request isWebSocketSetupRequest) and: [ aRequestContext webSocket notNil ])
Expand Down

0 comments on commit 944f3e1

Please sign in to comment.