Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #8594: Improve error message when greeting attempt is cancelled #8611

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #8594: Improve error message when greeting attempt is cancelled #8611

wants to merge 1 commit into from
+10 −10

Conversation

FirelightFlagboy
Copy link
Contributor

No description provided.

@FirelightFlagboy FirelightFlagboy requested a review from a team as a code owner October 4, 2024 07:23
@FirelightFlagboy FirelightFlagboy marked this pull request as draft October 4, 2024 07:24
@FirelightFlagboy FirelightFlagboy linked an issue Oct 4, 2024 that may be closed by this pull request
[CLI]: Improve error message in invite claim when greeter choose the wrong code #8594
Open
@FirelightFlagboy FirelightFlagboy marked this pull request as ready for review October 4, 2024 07:33
AureliaDolo
AureliaDolo approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@AureliaDolo AureliaDolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if there was a specific reason to use a screaming case previously ?

@FirelightFlagboy
Copy link
Contributor Author

Do you know if there was a specific reason to use a screaming case previously ?

IDK, maybe @AureliaDolo knows :trollface:

Maybe it's for a roudtrip parsing of raw string: FromStr -> Display -> FromStr
But we implement serde::{Serialization,Deserialization} for that 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AureliaDolo AureliaDolo AureliaDolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CLI]: Improve error message in invite claim when greeter choose the wrong code
2 participants
@FirelightFlagboy @AureliaDolo