Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve FUSE config and document it #8583

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

touilleMan
Copy link
Member

No description provided.

.add_capabilities(fuser::consts::FUSE_READDIRPLUS_AUTO)
.expect("Capability available");

// TODO: `FUSE_SPLICE_READ` seems to require `write_buf()` to be implemented, which is
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why read require write_buf, did you mean read_buf ?

Can you create an issue on fuser side ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nop it's write_buf

Can you create an issue on fuser side ?

This is not related to fuser, it's documented as such on libfuse

I've created an issue on fuser side to try to better understand what is the support of write_buf on fuser: cberner/fuser#298

@touilleMan touilleMan force-pushed the fuse-improved-config branch 2 times, most recently from 490b655 to 4541d10 Compare October 2, 2024 10:46
@@ -17,7 +17,12 @@ regex = { workspace = true }
winfsp_wrs = { workspace = true }

[target.'cfg(target_family = "unix")'.dependencies]
fuser = { workspace = true, features = ["libfuse", "abi-7-21"] }
# ABI 7.31 has been introduced in Linux 5.2 (2019-06-08), should be old enough
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be carefully tested?

A quick search shows that Ubuntu 22.10 (and older) started with initial kernel version older than 5.2. On Debian, only 12 (stable) started with a 6.x version.
Most up-to-date systems will meet the requirement, but I wouldn't be surprised if the administration still uses "old" RHEL/CentOS laptops. Maybe we should check that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't be concerned about this: if your kernel is still from 2019 that means your have never updated your system... then you have much bigger issues than not being able to run Parsec :trollface:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants