[MS] Updated locales user to member
#8361
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabienSvtr
force-pushed
the
ms-change-user-to-member
branch
from
1c9e956
to
50840ee
Compare
Ironicbay
reviewed
Sep 17, 2024
fabienSvtr
force-pushed
the
ms-change-user-to-member
branch
from
0474301
to
9c6dfed
Compare
fabienSvtr
force-pushed
the
ms-change-user-to-member
branch
from
0594da1
to
ee998a4
Compare
Ironicbay
approved these changes
Sep 17, 2024
Ironicbay
reviewed
Sep 17, 2024
Ironicbay
reviewed
Sep 17, 2024
client/src/locales/en-US.json
Outdated
| @@ -410,7 +410,7 @@ | |||
| "createFolder": "New folder", | |||
| "copyHere": "Copy here", | |||
| "import": "Import", | |||
| "itemCount": "No items | 1 item | {count} items", | |||
| "itemCount": "No items | Item : 1 | Items: {count}", | |||
There was a problem hiding this comment.
Suggested change
| "itemCount": "No items | Item : 1 | Items: {count}", | |
| "itemCount": "No items | Item: 1 | Items: {count}", |
mmmarcos
requested changes
Sep 17, 2024
There was a problem hiding this comment.
@fabienSvtr we've already started updating the docs, we should wait until the user guide is fully merged (see #8387) otherwise we the app will not be consistent with the docs.
client/src/locales/en-US.json
Outdated
| @@ -586,7 +586,7 @@ | |||
| }, | |||
| "configuration": { | |||
| "outsidersAllowed": "External profile", | |||
| "userLimit": "User limit", | |||
| "userLimit": "Profile limit (not including external)", | |||
There was a problem hiding this comment.
What does this means? wording does not seem very clear
client/src/locales/en-US.json
Outdated
| "inviteFailedOffline": "Failed to connect to the server. Please make sure you are online.", | ||
| "inviteFailedNotAllowed": "Only an administrator can invite new users into the organization.", | ||
| "inviteFailedNotAllowed": "Only an administrator can invite new members into the organization.", |
There was a problem hiding this comment.
Suggested change
| "inviteFailedNotAllowed": "Only an administrator can invite new members into the organization.", | |
| "inviteFailedNotAllowed": "Only an administrator can invite new members.", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Changed the word
usertomember.Waiting the issue #8387
Checklist
Before you submit this pull request, please make sure to: