Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MS] Use WorkspaceWatchedEntryChanged to refresh the files list instead of a fixed timer #7610

Merged
merged 1 commit into from
Jul 9, 2024
Merged

[MS] Use WorkspaceWatchedEntryChanged to refresh the files list instead of a fixed timer #7610

merged 1 commit into from
Jul 9, 2024

Conversation

Max-7
Copy link
Contributor

@Max-7 Max-7 commented Jun 17, 2024

Depends on #7424. Includes the code from that PR so that it's easier to test.

  • Keep changes in the pull request as small as possible
  • Ensure the commit history is sanitized
  • Give a meaningful title to your PR
  • Describe your changes
  • Link any dependent pull request in the description

@Max-7 Max-7 requested review from a team as code owners June 17, 2024 15:32
@Max-7 Max-7 changed the title Ms watch entries [MS] Use WorkspaceWatchedEntryChanged to refresh the files list instead of a fixed timer Jun 17, 2024
@FirelightFlagboy FirelightFlagboy changed the base branch from master to event-workspace-watched June 18, 2024 06:05
Base automatically changed from event-workspace-watched to master June 18, 2024 10:18
@FirelightFlagboy
Copy link
Contributor

You include @touilleMan commit, that are already present on master, could you rebase ?

@Max-7 Max-7 added this pull request to the merge queue Jul 9, 2024
Merged via the queue into master with commit 9616ee9 Jul 9, 2024
13 checks passed
@Max-7 Max-7 deleted the ms-watch-entries branch July 9, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicoTuxx NicoTuxx NicoTuxx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Max-7 @FirelightFlagboy @NicoTuxx