Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to create a api route. #7587

Merged
merged 4 commits into from
Jun 25, 2024
Merged

Document how to create a api route. #7587

merged 4 commits into from
Jun 25, 2024

Conversation

AureliaDolo
Copy link
Contributor

No description provided.

@AureliaDolo AureliaDolo force-pushed the aurelia/doc_route branch 2 times, most recently from 5838458 to 07b5daf Compare June 14, 2024 16:12
@AureliaDolo AureliaDolo marked this pull request as ready for review June 14, 2024 16:13
@AureliaDolo
Copy link
Contributor Author

I'm thinking about adding somewhere the full diff of what you have when you follow the doc with the given example, but I don't know how useful will it be, where to put it and how readable it is.

In my idea, if you want to add a route, you could apply the patch and then see where you need to add stuff.

Copy link
Contributor

@mmmarcos mmmarcos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these docs! Here are some comments.

docs/development/how_to_add_a_route.md Outdated Show resolved Hide resolved
docs/development/how_to_add_a_route.md Outdated Show resolved Hide resolved
docs/development/how_to_add_a_route.md Outdated Show resolved Hide resolved
docs/development/how_to_add_a_route.md Outdated Show resolved Hide resolved
docs/development/how_to_add_a_route.md Outdated Show resolved Hide resolved
docs/development/how_to_add_a_route.md Outdated Show resolved Hide resolved
docs/development/how_to_add_a_route.md Outdated Show resolved Hide resolved
docs/development/how_to_add_a_route.md Outdated Show resolved Hide resolved
docs/development/how_to_add_a_route.md Outdated Show resolved Hide resolved
docs/development/how_to_add_a_route.md Outdated Show resolved Hide resolved
@AureliaDolo AureliaDolo force-pushed the aurelia/doc_route branch 2 times, most recently from 4a4a0ea to d3e4a15 Compare June 17, 2024 14:51
Copy link
Contributor

@vxgmichel vxgmichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

docs/development/how_to_add_a_route.md Outdated Show resolved Hide resolved
docs/development/how_to_add_a_route.md Outdated Show resolved Hide resolved
docs/development/how_to_add_a_route.md Outdated Show resolved Hide resolved
docs/development/how_to_add_a_route.md Outdated Show resolved Hide resolved
docs/development/how_to_add_a_route.md Outdated Show resolved Hide resolved
docs/development/how_to_add_a_route.md Outdated Show resolved Hide resolved
@AureliaDolo AureliaDolo added this pull request to the merge queue Jun 25, 2024
Merged via the queue into master with commit c216688 Jun 25, 2024
12 checks passed
@AureliaDolo AureliaDolo deleted the aurelia/doc_route branch June 25, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants