Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Enzyme 0.11.0 #847

Merged
merged 4 commits into from
Jul 24, 2023
Merged

Test Enzyme 0.11.0 #847

merged 4 commits into from
Jul 24, 2023

Conversation

ChrisRackauckas
Copy link
Member

No description provided.

@ChrisRackauckas
Copy link
Member Author

@wsmoses it looks like we get 0 gradient issues with the latest Enzyme.

@wsmoses
Copy link

wsmoses commented Jul 13, 2023

Got a test/reproducer?

Also are you using the 0.11.5 that was released a few hours ago, or a different one?

Project.toml Outdated Show resolved Hide resolved
@ChrisRackauckas
Copy link
Member Author

It was 0.11.4. Was that known to have some issues? https://github.com/SciML/OrdinaryDiffEq.jl/actions/runs/5535634554/jobs/10102198548?pr=1984#step:6:628

Pretty much every test failed with it. Running 0.11.5 now.

@wsmoses
Copy link

wsmoses commented Jul 13, 2023

No correctness ones that I'm aware of, so having a test would be useful for sure.

@ChrisRackauckas
Copy link
Member Author

Yup when I allow v0.11.5 the error pop right back up. Suddenly gradients are either incorrect or zero. I'm at a hackathon this week and next so I cannot look into it deeper, so I'm going to hardcode back to v0.11.0 for now.

@wsmoses
Copy link

wsmoses commented Jul 23, 2023

I have confirmed at least one of your issues is bug in the KernelAbstractions extension package (see JuliaGPU/KernelAbstractions.jl#412), hence any Enzyme version bumps will not fix the issue, since the issue is in another package.

In any case it requires the fix to KA to land and be bumped, at least for your test to pass.

@ChrisRackauckas ChrisRackauckas merged commit 1997fb1 into master Jul 24, 2023
18 of 22 checks passed
@ChrisRackauckas ChrisRackauckas deleted the ChrisRackauckas-patch-3 branch July 24, 2023 15:16
@ChrisRackauckas
Copy link
Member Author

It looks like that was it. I still bumped the patch to keep life simple. Let's see what people throw back at me now 😅 . I think we're getting really close though, the errors are getting more obscure, really nice work @wsmoses!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants