Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Deps: StochasticDiffEq and OrdinaryDiffEq #1096

Merged
merged 11 commits into from
Sep 2, 2024

Conversation

prbzrg
Copy link
Member

@prbzrg prbzrg commented Aug 25, 2024

Fixes #1095

@prbzrg
Copy link
Member Author

prbzrg commented Aug 25, 2024

What do we do about StochasticDiffEq.alg_interpretation?

@ChrisRackauckas
Copy link
Member

We can make that a trait in SciMLBase and have StochasticDiffEq extend it.

@prbzrg
Copy link
Member Author

prbzrg commented Aug 25, 2024

Unrelated error LoadError: MethodError: no method matching Float64(::Tracker.TrackedReal{Float64}) repeated multiple times.
Other errors seem unrelated too. (except for UndefVarError: `alg_interpretation` not defined)

@ChrisRackauckas
Copy link
Member

Yes, that started showing up a bit ago. I have been meaning to track it down. I think SciML/DiffEqBase.jl@57b5aec might be related.

@ChrisRackauckas ChrisRackauckas marked this pull request as ready for review August 27, 2024 19:50
@ChrisRackauckas
Copy link
Member

Okay yeah the alg_interpretation needs to move to be https://github.com/SciML/SciMLBase.jl/blob/master/src/alg_traits.jl a SciMLBase trait that is extended by StochasticDiffEq

@ChrisRackauckas
Copy link
Member

Bump the SciMLBase and StochasticDiffEq minors.

@ChrisRackauckas ChrisRackauckas merged commit 6996fd5 into SciML:master Sep 2, 2024
13 of 16 checks passed
@ChrisRackauckas
Copy link
Member

Thanks for seeing this through!

@prbzrg prbzrg deleted the clear-12 branch September 2, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Depending on OrdinaryDiffEq?
2 participants