Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Forward Mode to use SciMLStructures #1085

Merged
merged 21 commits into from
Aug 19, 2024
Merged

Update Forward Mode to use SciMLStructures #1085

merged 21 commits into from
Aug 19, 2024

Conversation

DhairyaLGandhi
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Updates the forward mode dispatches to also use the SciMLStructures interface. As with elsewhere, only the tunable portion is respected while constructing the backpass. I have replaced the check for the compatibilty for p with that for SciMLStructures, but wanted feedback on whether this is correct. The previous check was trying to p <: AbstractArray so I think we should be covered if we get a SciMLStructure and canonically get the tunables from it.

Add any other context about the problem here.
Needs tests

@DhairyaLGandhi DhairyaLGandhi changed the title Dg/fwd Update Forward Mode to use SciMLStructures Jul 26, 2024
@DhairyaLGandhi
Copy link
Member Author

Needs to be tested with SciML/ModelingToolkit.jl#2929

@DhairyaLGandhi DhairyaLGandhi marked this pull request as ready for review August 12, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants