-
-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initial implementation of HomotopyContinuation interface #3114
base: master
Are you sure you want to change the base?
Conversation
end | ||
|
||
function HomotopyContinuationProblem(args...; kwargs...) | ||
error("Requires HomotopyContinuationExt") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expand this 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah there's probably a decent bit more work to be done here. I just opened the PR for visibility and as an RFC on implementation.
I think most of what's left now is documentation. It would also be nice to not require symbolic jacobians. I want to integrate that with |
Leave any Jac change for a future PR. Contain the scope a bit here. |
Could you point to what transformation you're referring to regarding rational functions? |
You can always multiply through by the denominators to make the system polynomial. If you look at the Catalyst extension you can see what @TorkelE did. |
Ah, I see what you mean now. Yeah that should be simple. |
Note, there is no reason not to leave rational systems for a follow up. Just having it on polynomial systems to start is nice! |
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.