New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid Perf Predictor crashing if rider has no weight #205

Merged

mayfield merged 1 commit into SauceLLC:master from nb:no-weight-perf-predictor-crash

Oct 4, 2024

Contributor

nb commented Oct 4, 2024

Check if ns.weight exists before converting, otherwise we will get a type error for trying to run toFixed(1) on undefined.

Cheers!

To test:

Go to https://www.strava.com/activities/1537067643#38485981109 and click Perf Predictor on any segment.
Nothing happens, except an error in the console.
When switching to the dev version with the fix below applied, the Perf Predictor shows up with weight field empty, but at least it shows up.


          Check if ns.weight exists before converting

0bdf367

Otherwise we will get a type error for trying to run `toFixed(1)` on
`undefined`.

mayfield merged commit 6e27d80 into SauceLLC:master

2 checks passed

Collaborator

mayfield commented Oct 4, 2024

Thank you @nb !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet