Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add better argument parsing for shell #112

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Add better argument parsing for shell #112

merged 1 commit into from
Jul 11, 2023

Conversation

gergocs
Copy link
Contributor

@gergocs gergocs commented Jun 27, 2023

Signed-off-by: Gergo Csizi [email protected]

@gergocs gergocs marked this pull request as ready for review June 27, 2023 13:13
@zherczeg
Copy link
Collaborator

zherczeg commented Jul 3, 2023

I am neutral about this change. It makes the shell more complex, but it allows better argument parsing.

clover2123
clover2123 approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@clover2123 clover2123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clover2123 clover2123 merged commit 2049751 into Samsung:interp Jul 11, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clover2123 clover2123 clover2123 approved these changes

@ksh8281 ksh8281 Awaiting requested review from ksh8281 ksh8281 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gergocs @zherczeg @clover2123