Implement showing Exceptions. #629
Conversation
Signed-off-by: Zoltan Herczeg [email protected]
|
I am sorry. I cannot get your intention from your PR message. |
|
There was a request for "Handling errors/segfaults" in #606. This patch catches errors in SandBox::run as requested and displays them on the client side. However there was a second part of the request that it should capture signals as well. I haven't implemented it yet, because I need some help how to do it. We can install signal handlers, but they only receive the signal number, so we cannot access the debugger since we have no context. How could we access the context? Shall we create a global variable? |
|
It seems that there was a misunderstanding about handling errors. |
|
Thank you for clarifying it. Please let me know if you need any changes. |
|
(Note: the patch limits the exception backtrace to 8 entries, we can extend this if more is needed) |
| if (!m_debugger || !m_debugger->enabled()) { | ||
| return; | ||
| } | ||
| m_debugger->sendString(Debugger::ESCARGOT_MESSAGE_PRINT_8BIT, output); | ||
| m_debugger->sendType(Debugger::ESCARGOT_MESSAGE_PRINT); | ||
| if (m_debugger->enabled()) { |
There was a problem hiding this comment.
Check for enabled debugger is already done in the above.
So please remove this if statement.
There was a problem hiding this comment.
Unfortunately during a send the connection can be dropped, so we need to check after each send whether we still have connection.
This could be reworked to return a true if sending is successful, or sending data does nothing if no connection is available. I think we should do it in a separate patch though because it affects other code.
There was a problem hiding this comment.
IMHO the latter approach in which send checks the connection before actually sending the data looks better. In this approach, we don't need to explicitly check the enabled debugger everytime when sending the data.
| String* message = error.toStringWithoutException(state); | ||
|
|
||
| debugger->sendType(Debugger::ESCARGOT_MESSAGE_EXCEPTION); | ||
| if (debugger->enabled()) { |
Please check that this how this feature should work. Regarding signals, the signal handler only receives a signal number, but no context pointer is passed. I could only access the debugger using a global variable. Shall I create a global variable for the debugger?