Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify tail call operations #1319

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Simplify tail call operations #1319

merged 1 commit into from
Feb 5, 2024

Conversation

clover2123
Copy link
Contributor

No description provided.

@ksh8281
Copy link
Contributor

ksh8281 commented Feb 1, 2024

I have one concern about memoty leak from tcoArgument buffer in interpreter.
how about allocate the tco argument buffer in stack like ObjectCreateData?
or we should clear tco argument buffer some how.

Signed-off-by: HyukWoo Park <[email protected]>
@clover2123
Copy link
Contributor Author

@ksh8281
I revert the shared buffer approach, so tail call will allocate an argument buffer on stack using alloca method like before.
I will improve this in the following patch

@ksh8281 ksh8281 merged commit c4ab1cf into Samsung:master Feb 5, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants