Update Symbol finalzer and description getter methods #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zherczeg
approved these changes
Jan 5, 2024
src/builtins/BuiltinSymbol.cpp
Outdated
| // If description is undefined, let descString be undefined. | ||
| if (!(argc == 0 || argv[0].isUndefined())) { | ||
| // NOTE) we represent `undefined` as nullptr here |
There was a problem hiding this comment.
Thank you for the review. fixed it.
src/runtime/Symbol.h
Outdated
| { | ||
| // nullptr of desc represents `undefined` |
There was a problem hiding this comment.
I would add this comment to the member
| { | ||
| return m_description; | ||
| ASSERT(!!m_finalizerData); |
There was a problem hiding this comment.
I don't see a hasFinalizerData, is there a way to check this somehow?
There was a problem hiding this comment.
This removeFinalizer will be called when it has a valid data by GC (it is guaranteed)
|
|
||
| for (size_t i = 0; i < list.size(); i++) { | ||
| // If SameValue(e.[[Symbol]], sym) is true, return e.[[Key]]. | ||
| if (list[i].symbol == sym) { |
There was a problem hiding this comment.
Maybe it is defined in the specification, but is it true that always maximum of one result is possible?
There was a problem hiding this comment.
Yes, only one unique Symbol (with each Symbol description) will be registered according to the spec.
Signed-off-by: HyukWoo Park <[email protected]>
Signed-off-by: HyukWoo Park <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.