Apply TCO for sequence and logical operations located at the end of the return statement #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
clover2123
commented
Oct 19, 2023
clover2123
commented
- remove unused parameter in toBoolean method
- optimize bytecode generations in sequence and logical operations
ksh8281
reviewed
Oct 23, 2023
src/api/EscargotPublic.h
Outdated
| @@ -982,7 +982,7 @@ class ESCARGOT_EXPORT ValueRef { | |||
| ESCARGOT_TYPEDARRAY_REF_LIST(DEFINE_VALUEREF_IS_AS); | |||
| #undef DEFINE_VALUEREF_IS_AS | |||
|
|
|||
| bool toBoolean(ExecutionStateRef* state); | |||
There was a problem hiding this comment.
IMHO we should not change public API if possible
and this requirements can be changed later by ECMAScript spec change
There was a problem hiding this comment.
I see :) I have reverted toBoolean change.
…he return statement Signed-off-by: HyukWoo Park <[email protected]>
ksh8281
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.