Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Windows UWP and ClangCL build test on github action #1234

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

ksh8281
Copy link
Contributor

@ksh8281 ksh8281 commented Jul 7, 2023

No description provided.

@ksh8281 ksh8281 force-pushed the work57 branch 10 times, most recently from ac55d1f to 06cdc27 Compare July 11, 2023 09:11
@ksh8281 ksh8281 changed the title Implement Windows UWP build test on github action Implement Windows UWP and ClangCL build test on github action Jul 11, 2023
Comment on lines +181 to +184
# clang-cl with cannot generate c++ exception code well
# if clang-cl bug fixed, we can add x64
arch: [
{cpu: "x86", flag: "-m32"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exception bug of clang-cl exists only for x64 target?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately no.. :(

  1. x86 cannot run every test262 tests
  2. x64 cannot run full octane tests

Copy link
Contributor

@clover2123 clover2123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clover2123 clover2123 merged commit 4913754 into Samsung:master Jul 12, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants