Fix global-await issue

* Print unhandled reject error for developer in shell * Fix await expression parsing bug Signed-off-by: Seonghyun Kim <[email protected]>
Samsung · Dec 1, 2023 · 799bc4f · 799bc4f
1 parent 184295c
commit 799bc4f
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/src/parser/esprima_cpp/esprima.cpp b/src/parser/esprima_cpp/esprima.cpp
@@ -3455,6 +3455,10 @@ class Parser {
                         }
                     }
 
+                    if (UNLIKELY(exprNode->type() == ASTNodeType::AwaitExpression)) {
+                        this->throwError(Messages::InvalidLHSInAssignment);
+                    }
+
                     if (!this->match(Substitution)) {
                         this->context->isAssignmentTarget = false;
                         this->context->isBindingElement = false;

diff --git a/src/shell/Shell.cpp b/src/shell/Shell.cpp
@@ -1097,6 +1097,11 @@ int main(int argc, char* argv[])
     Memory::setGCFrequency(24);
 
     PersistentRefHolder<VMInstanceRef> instance = VMInstanceRef::create();
+    instance->registerPromiseRejectCallback([](ExecutionStateRef* state, PromiseObjectRef* promise, ValueRef* value, VMInstanceRef::PromiseRejectEvent event) {
+        if (event == VMInstanceRef::PromiseRejectWithNoHandler) {
+            fprintf(stderr, "Unhandled promise reject %s:\n", value->toStringWithoutException(state->context())->toStdUTF8String().data());
+        }
+    });
     PersistentRefHolder<ContextRef> context = createEscargotContext(instance.get());
 
     if (getenv("GC_FREE_SPACE_DIVISOR") && strlen(getenv("GC_FREE_SPACE_DIVISOR"))) {

diff --git a/test/vendortest b/test/vendortest