Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[luci/service] Migrate shape inferences for Conv2D ops #14125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pcs1265
Copy link
Member

@pcs1265 pcs1265 commented Sep 29, 2024

This commit migrates shape inferences of Conv2D and DepthwiseConv2D to sinf::Algorithm.

ONE-DCO-1.0-Signed-off-by: Chansu Park [email protected]

This commit migrates shape inference of Conv2D and DepthwiseConv2D to sinf::Algorithm.

ONE-DCO-1.0-Signed-off-by: Chansu Park <[email protected]>
@pcs1265 pcs1265 requested review from a team September 29, 2024 23:42
@pcs1265
Copy link
Member Author

pcs1265 commented Sep 29, 2024

Related : #14115
Draft : #13950

This just migrates these functions and separates to dedicated file.
(It includes changing the return type to match with function header.)

If it needs to be divided into smaller changes, I am planning the following order.
1. Move infer_conv2d_type() function to HelperConv2Ds.h
3. Migrate Conv2D shape inference to sinf::Algorithm
4. Migrate DepthwiseConv2D shape inference to sinf::Algorithm

It seems more verbose if I split this...

@pcs1265 pcs1265 added SSAFY PR/ready for review It is ready to review. Please review it. labels Sep 29, 2024
@pcs1265 pcs1265 closed this Sep 30, 2024
@pcs1265 pcs1265 reopened this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR/ready for review It is ready to review. Please review it. SSAFY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant