Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[circle2circle] Add fuse_rmsnorm option #14069

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

seockho-kim
Copy link
Contributor

This commit adds 'fuse_rmsnorm' option to circle2circle.

ONE-DCO-1.0-Signed-off-by: Seockho Kim [email protected]

issue: #13964
draft: #13967

This commit adds 'fuse_rmsnorm' option to circle2circle.

ONE-DCO-1.0-Signed-off-by: Seockho Kim [email protected]
@seockho-kim seockho-kim requested a review from a team September 24, 2024 07:30
@@ -301,6 +302,7 @@ int entry(int argc, char **argv)
option_str_to_enum["fuse_preactivation_batchnorm"] = Algorithms::FusePreActivationBatchNorm;
option_str_to_enum["fuse_prelu"] = Algorithms::FusePRelu;
option_str_to_enum["fuse_gelu"] = Algorithms::FuseGelu;
option_str_to_enum["fuse_rmsnorm"] = Algorithms::FuseRmsNorm;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz add setting flag from luci/pass if this option is enabled.

Copy link
Contributor Author

@seockho-kim seockho-kim Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz add setting flag from luci/pass if this option is enabled.

Where's setting flag in luci pass? I'm sorry I couldn't understand it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, there was refactoring and has changed ... -_-;

Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanshpark seanshpark merged commit 93e5f9d into Samsung:master Sep 24, 2024
9 checks passed
@seockho-kim seockho-kim deleted the circle2circle_rmsnorm branch September 24, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants