Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRAFT][luci/service] Enhance handling CircleConst as reshape's shape #14034

Closed
wants to merge 1 commit into from
Closed

[DRAFT][luci/service] Enhance handling CircleConst as reshape's shape #14034

wants to merge 1 commit into from

Conversation

jongwonyang
Copy link
Member

@jongwonyang jongwonyang commented Sep 19, 2024 •
edited
Loading

This commit improves the robustness of handling CircleConst as the shape for the reshape operation.

  • This is the 2nd step in supporting dynamic shape inference for the reshape operation.
  • The existing shape inference logic already supports using CircleConst as the shape for reshape.
    • However, it relies on static_cast to check whether a dimension is known or not.
    • This approach worked because unknown dimensions were stored with the value 4294967295 (UINT32_MAX) and then cast to -1.
    • This commit refines this behavior by explicitly handling unknown dimensions.

Draft: #13999
Related: #13927

ONE-DCO-1.0-Signed-off-by: Jongwon Yang [email protected]

@jongwonyang
[luci/service] Support CircleConst as reshape's shape
ae2e783 
This commit enhances robustness in handling CircleConst as reshape's
shape.

ONE-DCO-1.0-Signed-off-by: Jongwon Yang <[email protected]>
@jongwonyang jongwonyang added DRAFT A draft issue or PR for sharing one's current working status and discussion. SSAFY labels Sep 19, 2024
@jongwonyang jongwonyang requested review from a team September 19, 2024 03:35
@jongwonyang jongwonyang marked this pull request as draft September 19, 2024 03:35
@zetwhite
Copy link
Contributor

IDK why nncc-debug and nncc-release failed, but code itself looks good to me :)

@jongwonyang jongwonyang mentioned this pull request Sep 19, 2024
Merged
@jongwonyang jongwonyang deleted the reshape-const-draft branch September 24, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icodo98 icodo98 icodo98 left review comments

Assignees
No one assigned
Labels
DRAFT A draft issue or PR for sharing one's current working status and discussion. SSAFY
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jongwonyang @zetwhite @icodo98