[nnpackage,res] support RoPE operation

[ys44kim]

This commit updates circle schema for RoPE op

ONE-DCO-1.0-Signed-off-by: youngsik kim [email protected]

draft : #13978
issue : #13972

[ys44kim]

@glistening
please review this PR.

[glistening]

1. We need version up of circle schema. (0.9 -> 0.10).
2. Usually we don't update circle schema for an addition of operator as we see 0.9 case. Because the version of circle_schema affects many other modules. Personally I prefer to update with other changes together. Let's hear others' opinions also.

[ys44kim]

1. We need version up of circle schema. (0.9 -> 0.10).

as far as I know, when release, version up.
did I know wrong? or do you mean to change the version in advance for the next release?
and, Is there a rule to version up?

[glistening]

as far as I know, when release, version up. did I know wrong?

First, I don't know how others manages the version.
However, Personally I believe the version should be up as soon as the content of circle_schema.fbs changes. At least, "Revision History" needs to contain the change log.

Second, the public release and the version of circle_schema.fbs should be independent. We don't need to wait or release publicly to update circle_schema.

Third, assume that you're right (though I don't like this style), you should not change the content under 0.9. It is the snapshot (read-only) for specific version when the version is named.

[glistening]

I don't want to block this PR. But it seems blocked.

@seanshpark Is it okay to update res/CircleSchema/0.9/circle_schema.fbs, which is used for frontend. ? I guess not.

$+$ @hseok-oh
Is it okay to update nnpackage/schema/circle_schema.fbs?

Just for your information,
netron uses nnpackage/schema/circle_schema.fbs as schema
See https://github.com/lutzroeder/netron/blob/f4d88dcc63db415358e250e9b067e9341a32c042/tools/circle#L14.

[hseok-oh]

OK. But please add comment in revision history of v0.9 (line 36~)

[ys44kim]

OK. But please add comment in revision history of v0.9 (line 36~)

thanks, i updated

[glistening]

I don't think it is a good idea to add change after 0.9 is already there.
Someone may see the different content of the same version of 0.9.
However, I don't block if other users (frontend, python-tools, ...) are okay.

$+$ @ejjeong

[ejjeong]

• FYI it's fine for circle-schema python package to use 0.9.
  • FYI its versioning scheme is ready to handle such a situation 🔗 (sorry for the internal link)
• Apparently, RMS_NORM has already been added without updating the schema version.
  • [nnpackage,res] Add RmsNorm op to circle schema #13983

[hseok-oh]

I think circle schema version 0.9 is not fixed schema yet, so it's OK to update schema without version up.
Runtime has no issue updating without version up.

---

(ADDED) If version is changed to 0.10, luci may use new module (maybe mio-circle10?), then it also be effected runtime ODC build indirectly.

[seanshpark]

luci may use new module

mio-circle09 fixed name will be is being used (#13665) and maybe renamed without version number someday (#13990)

[seockho-kim]

I don't want to block this PR. But it seems blocked.

@seanshpark Is it okay to update res/CircleSchema/0.9/circle_schema.fbs, which is used for frontend. ? I guess not.

• @hseok-oh Is it okay to update nnpackage/schema/circle_schema.fbs?

Just for your information, netron uses nnpackage/schema/circle_schema.fbs as schema See https://github.com/lutzroeder/netron/blob/f4d88dcc63db415358e250e9b067e9341a32c042/tools/circle#L14.

FYI, frontend now uses 'nnpackage/schema/circle_schema.fbs'
#13951

[glistening]

LGTM. By offline talk, I heard that python-tools is okay, and other internal tools uses commit id, not the version number.

[seanshpark]

LGTM