[luci/service] Support StridedSlice dynamic shape inference #13968
Conversation
This partially supports dynamic shape inference for StridedSlice op when input node has dynamic shape and other nodes are const and input node has static shape and begin, end nodes are non const. ONE-DCO-1.0-Signed-off-by: sunki <[email protected]>
A little bit simpler description 😅 This supports dynamic shape inference for StridedSlice op, |
| { | ||
| INTERNAL_EXN("StridedSlice strides node are not Constant"); | ||
| } | ||
| // TODO Support cases where the mask attributes are non-zero. |
There was a problem hiding this comment.
Do we need to consider this attributes when begin/end is not const?
I'm asking this question because I don't think there's a need to add this comment here,
if the attribute is not related to the if statement below.
There was a problem hiding this comment.
I thought that when the mask was set, some parts of the shape could be fixed. However, since there are no issues with inference now, it would be better to remove the comment.
ONE-DCO-1.0-Signed-off-by: sunki <[email protected]>
ONE-DCO-1.0-Signed-off-by: sunki <[email protected]>
This supports dynamic shape inference for StridedSlice op,
in case where the input node is dynamic or the begin/end nodes are not const.
ONE-DCO-1.0-Signed-off-by: sunki [email protected]