-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Update HowToBuildFromSource to use package.json #1749
Conversation
cc23bf0
to
4adbf06
Compare
4adbf06
to
dd300a1
Compare
4c0a333
to
0b5043b
Compare
03b7365
to
fce7b2f
Compare
This PR updates HowToBuildFromSource.md. This is to remove `npm vsce` package warning message. ONE-vscode-DCO-1.0-Signed-off-by: SeungHui Youn <[email protected]> Co-authored-by: Jiyoung Giuliana Yun <[email protected]> Co-authored-by: Dayoung Lee <[email protected]>
fce7b2f
to
8b25472
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks :-D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR updates HowToBuildFromSource.md.
This is to remove
npm vsce
package warning message.ONE-vscode-DCO-1.0-Signed-off-by: SeungHui Youn [email protected]
Co-authored-by: Jiyoung Giuliana Yun [email protected]
related : #1748