Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update HowToBuildFromSource to use package.json #1749

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

zetwhite
Copy link
Contributor

@zetwhite zetwhite commented Dec 5, 2023

This PR updates HowToBuildFromSource.md.
This is to remove npm vsce package warning message.

ONE-vscode-DCO-1.0-Signed-off-by: SeungHui Youn [email protected]
Co-authored-by: Jiyoung Giuliana Yun [email protected]

related : #1748

@zetwhite zetwhite requested review from dayo09 and a team and removed request for dayo09 December 5, 2023 03:06
docs/HowToBuildFromSource.md Outdated Show resolved Hide resolved
docs/HowToBuildFromSource.md Outdated Show resolved Hide resolved
@zetwhite zetwhite force-pushed the 1204/update-build-doc branch 2 times, most recently from 4c0a333 to 0b5043b Compare December 5, 2023 09:13
@zetwhite zetwhite force-pushed the 1204/update-build-doc branch 2 times, most recently from 03b7365 to fce7b2f Compare December 6, 2023 04:12
This PR updates HowToBuildFromSource.md.
This is to remove `npm vsce` package warning message.

ONE-vscode-DCO-1.0-Signed-off-by: SeungHui Youn <[email protected]>
Co-authored-by: Jiyoung Giuliana Yun <[email protected]>
Co-authored-by: Dayoung Lee <[email protected]>
Copy link
Contributor

@dayo09 dayo09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks :-D

Copy link
Contributor

@mhs4670go mhs4670go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@YongseopKim YongseopKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@jyoungyun jyoungyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jyoungyun jyoungyun merged commit 91aa464 into Samsung:main Dec 7, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants