Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JsonTracer] Deprecate JsonTracer #1645

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Conversation

dayo09
Copy link
Contributor

@dayo09 dayo09 commented Sep 18, 2023

This commit deprecates JsonTracer and shows trace files with default text viewer.

ONE-vscode-DCO-1.0-Signed-off-by: Dayoung Lee [email protected]

This commit deprecates JsonTracer and shows trace files with default text viewer.

ONE-vscode-DCO-1.0-Signed-off-by: Dayoung Lee <[email protected]>
@dayo09 dayo09 added the 2 approvals 2 approvals required to be merged label Sep 18, 2023
@dayo09 dayo09 requested a review from a team September 18, 2023 10:40
Copy link
Contributor

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me!
Is jsonTracer now deprecated?

@dayo09
Copy link
Contributor Author

dayo09 commented Sep 19, 2023

@shs-park

Is jsonTracer now deprecated?

Sure. We plan to introduce a new viewer porting from original catapult project. :-D

@dayo09 dayo09 requested a review from a team September 19, 2023 02:38
Copy link
Collaborator

@jyoungyun jyoungyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jyoungyun jyoungyun merged commit 9c82656 into Samsung:main Sep 19, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 approvals 2 approvals required to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants