Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OneExplorer] Add delete shortcut #1589

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

dayo09
Copy link
Contributor

@dayo09 dayo09 commented Jun 26, 2023

This commit adds delete shortcut.

ONE-vscode-DCO-1.0-Signed-off-by: Dayoung Lee [email protected]

This commit adds delete shortcut.

ONE-vscode-DCO-1.0-Signed-off-by: Dayoung Lee <[email protected]>
@dayo09 dayo09 requested a review from a team June 26, 2023 06:59
@dayo09 dayo09 added the 2 approvals 2 approvals required to be merged label Jun 26, 2023
Copy link
Collaborator

@jyoungyun jyoungyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dayo09 dayo09 mentioned this pull request Jun 26, 2023
3 tasks
@dayo09
Copy link
Contributor Author

dayo09 commented Jun 27, 2023

@Samsung/one-vscode_committers PTAL :-D

Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanshpark
Copy link
Contributor

All test has finished by UI is still showing it's running.
I think it's OK to land.

@seanshpark seanshpark merged commit 986470c into Samsung:main Jun 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 approvals 2 approvals required to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants