Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: Add sub-commands related to challenges #20

Closed
wants to merge 4 commits into from

Conversation

vpchung
Copy link
Member

@vpchung vpchung commented Mar 28, 2024

Fixes (partially) #3

Changelog

Sub-commands added:

Subcommand Description
create Create a new challenge site

Preview

  • create
    $ cnb-tools challenge create "New challenge!" -t 2
    

@vpchung vpchung self-assigned this Mar 28, 2024
@pep8speaks
Copy link

Hello @vpchung! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 3:1: F401 'synapseclient.Project' imported but unused
Line 6:1: F401 'cnb_tools.classes.participant.Participant' imported but unused

Line 12:1: F401 'cnb_tools.classes.challenge.Challenge' imported but unused
Line 19:46: F722 syntax error in forward annotation 'New challenge name'
Line 23:13: F821 undefined name 'tasks_count'
Line 23:30: F821 undefined name 't'
Line 23:41: F722 syntax error in forward annotation 'Number of challenge tasks (default: 1)'
Line 29:13: F821 undefined name 'private'
Line 30:13: F821 undefined name 'p'
Line 31:18: F722 syntax error in forward annotation 'Challenge should be private, even to the Sage CNB Team (default: false)'
Line 31:89: E501 line too long (91 > 88 characters)

Copy link

sonarcloud bot commented Apr 4, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vpchung
Copy link
Member Author

vpchung commented Apr 10, 2024

Closing this one for now, until #24 is addressed.

@vpchung vpchung closed this Apr 10, 2024
@vpchung vpchung deleted the feat-3_challenges branch May 16, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants