[온보딩] step02 썸네일 등록 시 아이폰 이미지 확장자(heic) 업로드 안되는 현상 수정 #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
이미지 업로드가 되는 것을 진행해놓은 상태에서 다시 고용량 이미지를 추가하면 이미지 업로드가 되는 현상이 있어 이를 수정하였습니다.
|
imeureka
approved these changes
Mar 13, 2024
urjimyu
approved these changes
Mar 13, 2024
| @@ -57,7 +57,7 @@ const ThumbnailInput = React.memo((props: ThumbnailInputProps) => { | |||
| <S.IcEmptyThumbnailWrapper> | |||
| <input | |||
| type='file' | |||
| accept='image/jpeg, image/png, image/gif, image/heic ' | |||
| accept='image/jpeg, image/png, image/gif, image/heic, image/webp, image/HEIC' | |||
There was a problem hiding this comment.
앗 이거 저도 수정해야 하는데, MIME type은 대소문자 구분을 하지 않고 주로 소문자로 쓰인다고 해서 image/heic만 유지해도 될 것 같아요!
|
|
||
| const usePreviewImage = () => { | ||
| const { previewImageInfo, updatePreviewImageInfo } = usePreviewImageContext(); | ||
|
|
||
| const handleImageUpload = (event: React.ChangeEvent<HTMLInputElement>) => { | ||
| const { files } = event.target; | ||
| const uploadFalse = () => { |
There was a problem hiding this comment.
이 부분을 함수 분리하셨군요! 가독성이 더 좋아졌네요👍
hoeun0723
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈 넘버
구현 사항
Need Review
지민님이 먼저 예외처리 발견해주셔서 해당 코드 참고하여 작성하였습니다!
감사합니다 ㅎㅎ
함수 분리 부분 언제든 리뷰 환영입니다 :)
📸 스크린샷
Reference