Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[온보딩] 시간 선택 스크롤 바 라이브러리로 교체 & 파일 용량 압축 라이브러리 사용 #478

Merged
merged 21 commits into from
Mar 11, 2024

Conversation

ExceptAnyone
Copy link
Member

@ExceptAnyone ExceptAnyone commented Mar 11, 2024

이슈 넘버

구현 사항

  • 시간 선택 라이브러리 MUI로 변경
  • 이미지 최적화 (react-image-file-resizer)
  • 서스펜스를 활용한 스켈레톤도 여기 브랜치에서 작업하다가 그냥 나누어서 작업하는게 좋을 것 같아서 미리 PR올립니다!

Need Review

  • ~ 부분 이렇게 구현했어요, 피드백 부탁해요!

📸 스크린샷

2024-03-11.11.09.34.mov

Reference

@ExceptAnyone ExceptAnyone added feat💡 기능 구현 온보딩 📝 방 만들기 페이지 labels Mar 11, 2024
@ExceptAnyone ExceptAnyone self-assigned this Mar 11, 2024
Copy link

github-actions bot commented Mar 11, 2024

PR Preview Action v1.4.6
🚀 Deployed preview to https://SWEET-DEVELOPERS.github.io/sweet-client/pr-preview/pr-478/
on branch gh-pages at 2024-03-11 14:58 UTC

Comment on lines 63 to 73
// else {
// // 이미지 너비가 허용된 범위 내에 있을 때
// updatePreviewImageInfo({
// isImageUploaded: true,
// file: selectedFiles[0],
// previewImage: URL.createObjectURL(selectedFiles[0]),
// imageName: finalImageName,
// });
// console.log('imageName', imageName);
// console.log('finalImageName', finalImageName);
// }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주석 처리 필요가 없으면 삭제해도 좋을 거 같아요 !!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 지웠슴다 ㅎㅎ!!

Copy link
Contributor

@urjimyu urjimyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

시간 선택 라이브러리 수정 후에 깔끔해진 게 느껴져요!ㅎㅎ 파일 압축 관련되어 수정하신 것도 확인했습니다 최고👍

@ExceptAnyone ExceptAnyone merged commit a8eaa41 into develop Mar 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat💡 기능 구현 온보딩 📝 방 만들기 페이지
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants