[마이페이지] 로그아웃 버튼 클릭 시 모달 나타내기 #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
urjimyu
approved these changes
Mar 11, 2024
| @@ -64,6 +64,7 @@ const GiftAddPageLayout = ({ | |||
| setIsModalOpen={setIsModalOpen} | |||
| onClickDelete={handleClickConfirmDeleteBtn} | |||
| clickedItem={clickedItem} | |||
| okButtonText='네, 삭제할게요' | |||
| console.log(response); | ||
| }); | ||
| localStorage.clear(); | ||
| navigate('/'); |
There was a problem hiding this comment.
저희 리팩토링 때 같이 navigate 좀 더 안전하게 사용하는 법 연구해봐요!!
노션에 적어두겠습니다잇!
There was a problem hiding this comment.
정말 맞아요 !!! 따로 빼야 좋은데 좋은 리마인드 감사합니다 !!
Comment on lines
+70
to
+75
| <DeleteModal | ||
| setIsModalOpen={setIsModalOpen} | ||
| onClickDelete={isLogout} | ||
| okButtonText='네, 할게요.' | ||
| > | ||
| 정말 로그아웃하시겠어요? |
ExceptAnyone
approved these changes
Mar 11, 2024
imeureka
approved these changes
Mar 11, 2024
…ELOPERS/sweet-client into feat/#444-logout_modal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈 넘버
구현 사항
Need Review
=> 해당 부분 다시 한번 더 확인해 봤는데, 로그아웃버튼 자체에서 모달을 띄워주는게 아닌, 마이페이지 자체에서 띄워주는거여서 여기서 더 추가 적인 코드분리는 안 될 거 같다라는 판단이 들었습니다 !
해당 부분 리뷰도 언제든지 환영이에요 !
📸 스크린샷
bandicam.2024-03-10.18-51-22-042.mp4
Reference