tf-a-tools: fix rot-key-pw to always NULL terminate #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The call to 'strncpy' does not NULL terminate the target string. Neither the allocation of memory for 'rot_key_pw', nor the call to strncpy had into account the NULL termination character which may lead to issues if the adjacent memory is not zero-init. Signed-off-by: Mike Wadsten <[email protected]> Signed-off-by: Hector Palacios <[email protected]>
|
This should be back-ported to kirkstone, too. |
|
Thanks Hector for your contribution. I have entered internal ticket for analysis and probable integration. |
|
Should be part of next release that si V5.1.1 (in W46). Thanks a gain for your contribution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to 'strncpy' does not NULL terminate the target string.
Neither the allocation of memory for 'rot_key_pw', nor the call to strncpy had into account the NULL termination character which may lead to issues if the adjacent memory is not zero-init.