Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MessageHeader.CurrentProgramName in tests #1963

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

rkm
Copy link
Member

@rkm rkm commented Oct 7, 2024

Proposed Changes

Set MessageHeader.CurrentProgramName once at the start of each test fixture (project / assembly) instead of individually in each test. Fixes cases where tests would fail if run individually.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by the @SMI/Reviewers team

Issues

@rkm rkm requested a review from a team October 7, 2024 13:41
@rkm rkm enabled auto-merge (rebase) October 7, 2024 13:41
jas88
jas88 previously approved these changes Oct 7, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.82%. Comparing base (373e9a1) to head (f0c5f64).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1963   +/-   ##
=======================================
  Coverage   64.82%   64.82%           
=======================================
  Files         181      181           
  Lines        6538     6538           
  Branches      963      963           
=======================================
  Hits         4238     4238           
  Misses       2017     2017           
  Partials      283      283           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rkm rkm requested a review from a team October 10, 2024 11:22
@rkm rkm merged commit f547cf4 into main Oct 10, 2024
19 checks passed
@rkm rkm deleted the fix/messageheader-progname-tests branch October 10, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants