Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: update genfscon documentation #22

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Conversation

cgzones
Copy link
Contributor

@cgzones cgzones commented Mar 20, 2023

Partial paths can be used generally for virtual kernel filesystems, e.g. cgroup2, securityfs, selinuxfs, and not just for the proc filesystem.

The genfscon statement supports an optional filetype specifier.

@stephensmalley stephensmalley self-requested a review July 27, 2023 13:23
Copy link
Member

@stephensmalley stephensmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The situation is somewhat more complex than described here. See SELinuxProject/selinux-kernel#2 for discussion of safety and use of genfscon. The kernel mechanism itself does not limit use of genfscon to only these cases; one can for example use it to label an initramfs-based rootfs, or a squashfs or even technically ext4 (but the latter wouldn't be safe).

@pcmoore pcmoore changed the title notebook: update genfscon documentation RFE: update genfscon documentation Jul 27, 2023
@pcmoore pcmoore added enhancement New feature or request pending/revision Requires additional changes labels Jul 27, 2023
@jbrindle
Copy link
Contributor

@cgzones Any chance you can publish an update to this based on Stephen's comment above, or would you prefer us to pick it up?

@cgzones
Copy link
Contributor Author

cgzones commented Aug 30, 2023

Updated the wording a bit, feel free to suggest improvements.

@stephensmalley
Copy link
Member

Reviewed-by: Stephen Smalley [email protected]

src/file_labeling_statements.md Outdated Show resolved Hide resolved
Partial paths can be used generally for virtual kernel filesystems, e.g.
cgroup2, securityfs, selinuxfs, and not just for the proc filesystem.

The genfscon statement supports an optional filetype specifier.

Signed-off-by: Christian Göttsche <[email protected]>
@jbrindle
Copy link
Contributor

reviewed-by: Joshua Brindle [email protected]

@jbrindle jbrindle merged commit 4f5a43c into SELinuxProject:main Aug 30, 2023
5 checks passed
@cgzones cgzones deleted the genfscon branch August 30, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pending/revision Requires additional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants