Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to xcframework #82

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

embassem
Copy link

use xcframeworks for dependencies
update min dependencies version

update min dependencies version
@dreampiggy
Copy link
Contributor

dreampiggy commented Sep 19, 2023

Carthage........... :(


To tell the truth, all Carthage supports is not always guranteed to be supported from someday. SPM and CocoaPods is the still the preferred way.

To change the Carthage dependency from raw framework into xcframework, this need WebPCoder itself also provide the xcframework Xcode scheme, so that as you (You're the sub-dependency of WebPCoder), which is a pain.

@embassem
Copy link
Author

but libwebp-Xcode supports Carthage, and it does not have any dependencies, it can easily distributed as an xcframework or when building SDWebImageWebPCoder It will build xcframework for it's dependencies including libwebp-Xcode

or we can add a pre-compiled xcframework to the release artifact :)

yes Carthage is not been updated and maintained for a while now, but it is the dependency manager that can provide a pre-build framework and support dependencies, SPM with binary does not support dependencies.

@dreampiggy
Copy link
Contributor

dreampiggy commented Sep 21, 2023

And

update min dependencies version

I don't find anything useful for this. The API we used (See SDImageWebPCoder.m) still exists and not changed from 1.0.0->1.3.2, why update ?

As a consumer or downstream dependency, you can always limit the libwebp version by yourself, no need to make the compatible version range more aggressively for this repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants