Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the new way for AnimatedImageViewWrapper, fix the transition visual jump between placeholderImage and final image #325

Closed
wants to merge 3 commits into from
Closed

Use the new way for AnimatedImageViewWrapper, fix the transition visual jump between placeholderImage and final image #325

wants to merge 3 commits into from

Conversation

dreampiggy
Copy link
Collaborator

This close the issue during the changes of #324

@dreampiggy dreampiggy added the animated image AnimatedImage struct label Jul 1, 2024
@dreampiggy dreampiggy added the API API changes label Jul 1, 2024
@dreampiggy
Copy link
Collaborator Author

The private API wrapped is exposed by accident. So I'd decide to remove this. People who previouslly use onViewCreateBlock does not get effected

@dreampiggy
Copy link
Collaborator Author

dreampiggy commented Jul 1, 2024 •
edited
Loading

Found serious regression on macOS. That _NSImageViewSimpleImageView no longer exists and cause SDAnimatedImageView animation buggy.

Close for now and use another workaround

@dreampiggy dreampiggy closed this Jul 1, 2024
@dreampiggy
Copy link
Collaborator Author

dreampiggy commented Jul 1, 2024 •
edited
Loading

image

compared to previous version:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
animated image AnimatedImage struct API API changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dreampiggy