Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid adding _format to delete calls #427

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

AmirthavalliG
Copy link
Member

FHIR Specification doesn't say _format can be added to delete calls. FHIR Model adds it by default
The delete interaction removes an existing resource. The interaction is performed by an HTTP DELETE command as shown:

  DELETE [base]/[type]/[id]

The request body SHALL be empty.
https://www.hl7.org/fhir/http.html#delete

FHIR Specification doesn't say _format can be added to delete calls
The delete interaction removes an existing resource. The interaction is performed by an HTTP DELETE command as shown:

  DELETE [base]/[type]/[id]
The request body SHALL be empty.
@coveralls
Copy link

coveralls commented Feb 5, 2024

Coverage Status

coverage: 95.712% (+0.004%) from 95.708%
when pulling 04fe7d1 on fix/unecessary-param
into d6dd790 on master.

@AmirthavalliG AmirthavalliG merged commit b2a40f2 into master Feb 5, 2024
6 checks passed
@AmirthavalliG AmirthavalliG deleted the fix/unecessary-param branch February 5, 2024 14:16
openui5fhirbot added a commit that referenced this pull request Feb 5, 2024
## [2.3.5](v2.3.4...v2.3.5) (2024-02-05)

### Bug Fixes

* avoid adding _format to delete calls ([#427](#427)) ([b2a40f2](b2a40f2))
@openui5fhirbot
Copy link
Collaborator

🎉 This PR is included in version 2.3.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants