Skip to content

Quality of life improvements #87

Quality of life improvements

Quality of life improvements #87

This check has been archived and is scheduled for deletion. Learn more about checks retention
GitHub Actions / clippy succeeded Jun 25, 2023 in 0s

clippy

6 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 6
Note 0
Help 0

Versions

  • rustc 1.72.0-nightly (f7ca9df69 2023-06-24)
  • cargo 1.72.0-nightly (03bc66b55 2023-06-23)
  • clippy 0.1.72 (f7ca9df 2023-06-24)

Annotations

Check warning on line 1101 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

passing a unit value to a function

warning: passing a unit value to a function
    --> src/lib.rs:1101:38
     |
1101 |             init_from_closure(|slot| Ok(init.__init(slot).unwrap())) //cannot fail
     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
help: move the expression in front of the call and replace it with the unit literal `()`
     |
1101 ~             init_from_closure(|slot| {
1102 +                 init.__init(slot).unwrap();
1103 +                 Ok(())
1104 ~             }) //cannot fail
     |

Check warning on line 1087 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

passing a unit value to a function

warning: passing a unit value to a function
    --> src/lib.rs:1087:17
     |
1087 |                 Ok(init.__pinned_init(slot).unwrap()) // cannot fail
     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
     = note: `#[warn(clippy::unit_arg)]` on by default
help: move the expression in front of the call and replace it with the unit literal `()`
     |
1087 ~                 init.__pinned_init(slot).unwrap();
1088 ~                 Ok(()) // cannot fail
     |

Check warning on line 1138 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded sub `cfg` when there is only one condition

warning: unneeded sub `cfg` when there is only one condition
    --> src/lib.rs:1138:7
     |
1138 | #[cfg(any(feature = "alloc"))]
     |       ^^^^^^^^^^^^^^^^^^^^^^ help: try: `feature = "alloc"`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg

Check warning on line 1107 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded sub `cfg` when there is only one condition

warning: unneeded sub `cfg` when there is only one condition
    --> src/lib.rs:1107:7
     |
1107 | #[cfg(any(feature = "alloc"))]
     |       ^^^^^^^^^^^^^^^^^^^^^^ help: try: `feature = "alloc"`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg

Check warning on line 258 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded sub `cfg` when there is only one condition

warning: unneeded sub `cfg` when there is only one condition
   --> src/lib.rs:258:7
    |
258 | #[cfg(any(feature = "alloc"))]
    |       ^^^^^^^^^^^^^^^^^^^^^^ help: try: `feature = "alloc"`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg

Check warning on line 255 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded sub `cfg` when there is only one condition

warning: unneeded sub `cfg` when there is only one condition
   --> src/lib.rs:255:7
    |
255 | #[cfg(any(feature = "alloc"))]
    |       ^^^^^^^^^^^^^^^^^^^^^^ help: try: `feature = "alloc"`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg
    = note: `#[warn(clippy::non_minimal_cfg)]` on by default