Quality of life improvements #197
y86-devscheduled.yml
on: pull_request
ubuntu / nightly
43s
ubuntu / nightly / updated
45s
Annotations
2 errors and 6 warnings
|
ubuntu / nightly
Process completed with exit code 101.
|
|
ubuntu / nightly / updated
Process completed with exit code 101.
|
|
passing a unit value to a function:
src/lib.rs#L1227
warning: passing a unit value to a function
--> src/lib.rs:1227:38
|
1227 | init_from_closure(|slot| Ok(init.__init(slot).unwrap())) //cannot fail
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
help: move the expression in front of the call and replace it with the unit literal `()`
|
1227 ~ init_from_closure(|slot| {
1228 + init.__init(slot).unwrap();
1229 + Ok(())
1230 ~ }) //cannot fail
|
|
|
passing a unit value to a function:
src/lib.rs#L1213
warning: passing a unit value to a function
--> src/lib.rs:1213:17
|
1213 | Ok(init.__pinned_init(slot).unwrap()) // cannot fail
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
= note: `#[warn(clippy::unit_arg)]` on by default
help: move the expression in front of the call and replace it with the unit literal `()`
|
1213 ~ init.__pinned_init(slot).unwrap();
1214 ~ Ok(()) // cannot fail
|
|
|
unneeded sub `cfg` when there is only one condition:
src/lib.rs#L1264
warning: unneeded sub `cfg` when there is only one condition
--> src/lib.rs:1264:7
|
1264 | #[cfg(any(feature = "alloc"))]
| ^^^^^^^^^^^^^^^^^^^^^^ help: try: `feature = "alloc"`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg
|
|
unneeded sub `cfg` when there is only one condition:
src/lib.rs#L1233
warning: unneeded sub `cfg` when there is only one condition
--> src/lib.rs:1233:7
|
1233 | #[cfg(any(feature = "alloc"))]
| ^^^^^^^^^^^^^^^^^^^^^^ help: try: `feature = "alloc"`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg
|
|
unneeded sub `cfg` when there is only one condition:
src/lib.rs#L258
warning: unneeded sub `cfg` when there is only one condition
--> src/lib.rs:258:7
|
258 | #[cfg(any(feature = "alloc"))]
| ^^^^^^^^^^^^^^^^^^^^^^ help: try: `feature = "alloc"`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg
|
|
unneeded sub `cfg` when there is only one condition:
src/lib.rs#L255
warning: unneeded sub `cfg` when there is only one condition
--> src/lib.rs:255:7
|
255 | #[cfg(any(feature = "alloc"))]
| ^^^^^^^^^^^^^^^^^^^^^^ help: try: `feature = "alloc"`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg
= note: `#[warn(clippy::non_minimal_cfg)]` on by default
|