Use a white square emoji for blanks #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the park uses a mixture of regular spaces and emoji the alignment will not be preserved nicely in many applications, especially web browsers, because the size of the regular space is not a match for the size of emojis used. Emoji themselves are not all guaranteed to be the same size in all fonts, but at if we use a 'white large square' it appears to be a more reliable size match for the rest of the emoji. Signed-off-by: Daniel P. Berrangé <[email protected]>
|
Reviewed-by: Philippe Mathieu-Daudé [email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the park uses a mixture of regular spaces and emoji the alignment
will not be preserved nicely in many applications, especially web
browsers, because the size of the regular space is not a match for
the size of emojis used.
Emoji themselves are not all guaranteed to be the same size in all
fonts, but at if we use a 'white large square' it appears to be a
more reliable size match for the rest of the emoji.
The downside is that it gives a bit of an appearance of a tiled patio,
but personally I prefer that to mangled alignment, so figure it is
probably a net win.