Skip to content

Commit

Permalink
[MOD] #335 Extra Key 상수 Navigator 인터페이스로 분리
Browse files Browse the repository at this point in the history
  • Loading branch information
dongx0915 committed Feb 22, 2024
1 parent e193e42 commit 4aef528
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 3 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
package com.runnect.runnect.navigator.feature.detail

import com.runnect.runnect.navigator.base.Navigator

interface CourseDetailNavigator : Navigator {
companion object {
const val EXTRA_PUBLIC_COURSE_ID = "EXTRA_PUBLIC_COURSE_ID"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import com.runnect.runnect.data.dto.CourseData
import com.runnect.runnect.databinding.ActivityCourseDetailBinding
import com.runnect.runnect.domain.entity.CourseDetail
import com.runnect.runnect.domain.entity.EditableCourseDetail
import com.runnect.runnect.navigator.feature.detail.CourseDetailNavigator
import com.runnect.runnect.presentation.MainActivity
import com.runnect.runnect.presentation.countdown.CountDownActivity
import com.runnect.runnect.presentation.detail.CourseDetailRootScreen.COURSE_DISCOVER
Expand Down Expand Up @@ -98,7 +99,7 @@ class CourseDetailActivity :
intent.getCompatibleSerializableExtra<CourseDetailRootScreen>(EXTRA_ROOT_SCREEN)?.let {
rootScreen = it
}
publicCourseId = intent.getIntExtra(EXTRA_PUBLIC_COURSE_ID, -1)
publicCourseId = intent.getIntExtra(CourseDetailNavigator.EXTRA_PUBLIC_COURSE_ID,-1)
Timber.tag("intent-publicCourseId").d("$publicCourseId")
}

Expand Down Expand Up @@ -167,7 +168,11 @@ class CourseDetailActivity :
intent?.let { newIntent ->
newIntent.getCompatibleSerializableExtra<CourseDetailRootScreen>(EXTRA_ROOT_SCREEN)
?.let { rootScreen = it }
publicCourseId = newIntent.getIntExtra(EXTRA_PUBLIC_COURSE_ID, -1)

publicCourseId = newIntent.getIntExtra(
CourseDetailNavigator.EXTRA_PUBLIC_COURSE_ID,
-1
)
getCourseDetail()
}
}
Expand Down Expand Up @@ -620,7 +625,6 @@ class CourseDetailActivity :
private const val RES_STAMP_TYPE = "drawable"

private const val EXTRA_ROOT_SCREEN = "rootScreen"
private const val EXTRA_PUBLIC_COURSE_ID = "publicCourseId"
private const val EXTRA_COURSE_DATA = "CourseData"
private const val EXTRA_FRAGMENT_REPLACEMENT_DIRECTION = "fragmentReplacementDirection"
private const val EXTRA_FROM_COURSE_DETAIL = "fromCourseDetail"
Expand Down

0 comments on commit 4aef528

Please sign in to comment.