Appveyor enh pr with good indent

.github/ISSUE_TEMPLATE.md

@@ -22,5 +22,4 @@ In case of BSOD, please attach minidump or dump analyze output.
 
 # Support
  - Usage: <personal/commercial> - <testing/development/production>
- - Your personal priority to solve this issue: <dontCare/low/med/high/top/urgent/ASAP/iCanPay/iWillSellMyOrgans>
  - Support ability: <programming C, can create pull request / deeptesting / investigate driver issues / donate others / etc.>

.gitignore

@@ -40,3 +40,5 @@ ReleasePS
 /dokan_wix/disk1
 /dokan_wix/setup.inf
 /dokan_wix/setup.rpt
+/fstools
+/winfstest

CHANGELOG.md

@@ -3,15 +3,52 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/).
 
-## [Unreleased] - 1.0.1.0000
+## [Unreleased] - 1.0.3.1000
+
+## [1.0.2.1000] - 2017-01-20
+### Added
+- FUSE - Add libfuse-compatible pkg-config
+- Mirror - Add `DOKAN_OPTION_FILELOCK_USER_MODE` option with `/f`
+
+### Changed
+- FUSE - Use pkg-config for building mirror
+- Kernel - Many improvement allocation stack and heap
+- Kernel - Enable PAGED_CODE for `DokanCheckShareAccess`
+- Mirror - Return empty SACL if mirror doesn't have SeSecurityPrivilege
+- Library - Use DeleteMountPoint for removing reparse point instead of `DeleteVolumeMountPoint`
+- Library - Remove Redundant control flow jump 
+
+### Fixed
+- Driver - Less wide locking
+- Kernel - Align security descriptor to 4-byte boundary in `DokanDispatchSetSecurity`
+- Library - Fix dokan context leak when CreateFile fail 
+- Kernel - Fix BSOD. When drive is started using n option and procmon is attached the rename of files in the root folder is not possible
+- Kernel - Relative path rename
+- Library - Write Set correctly the userland NtStatus
+
+## [1.0.1.1000] - 2016-11-04
+### Added
+- Library - `DokanMapStandardToGenericAccess` - Convert `IRP_MJ_CREATE` DesiredAccess to generic rights.
 
 ### Changed
 - Driver - Use atomic operations for FCB and CCB flags instead of locks.
 - Update Windows SDK to 10.0.14393
-- Library - Call now DeleteFile and DeleteDirectory with DeleteOnClose set at a delete request OR canceled.
+- Library - Call now `DeleteFile` and `DeleteDirectory` with `DeleteOnClose` set at a delete request OR canceled.
+- Driver -  Double check that the returned security descriptor is valid before returning success on QuerySecurity.
+- Installer - Enable dev tools by default.
+- Driver - Return `STATUS_FILE_LOCKED_WITH_ONLY_READERS` during `PreAcquireForSectionSynchronization` when locked only with readers.
+- Mirror - Open handle when `GetFileInformation` requested after cleanup.
+- Kernel - Remove FCB `Resource` and `MainResource`. Use FCB Header `Resource` instead allocated with LookasideList.
 
 ### Fixed
-- Driver - `CcPurgeCacheSection` could cause deadlock when fcb was locked in the same time.
+- Driver - `CcPurgeCacheSection` could cause deadlock when FCB was locked in the same time.
+- Driver - Deadlock on related FCB.
+- FUSE - Race condition in Dokan FUSE.
+- Driver - BSOD issue related to filesystem mount on Windows 10 build 14936.
+- Driver - Unlock FCB during `FsRtlOplockBreakH` to let other request Lock FCB.
+- FUSE - Set correctly Authenticated Users rights (Explorer menu context).
+- Mirror - Reject when trying to open a file as a directory.
+- Driver - Return correct status for `FSCTL_FILESYSTEM_GET_STATISTICS` - Can now net share on Windows Server 2012 R2
 
 ## [1.0.0.5000] - 2016-09-20
 ### Added
@@ -198,7 +235,8 @@ Latest Dokan version from Hiroki Asakawa.
  [http://dokan-dev.net/en]( http://web.archive.org/web/20150419082954/http://dokan-dev.net/en/)
 
 
-[Unreleased]: https://github.com/dokan-dev/dokany/compare/v1.0.0...master
+[Unreleased]: https://github.com/dokan-dev/dokany/compare/v1.0.1...master
+[1.0.1.1000]: https://github.com/dokan-dev/dokany/compare/v1.0.0...v1.0.1
 [1.0.0.5000]: https://github.com/dokan-dev/dokany/compare/v0.8.0...v1.0.0
 [0.8.0]: https://github.com/dokan-dev/dokany/compare/v0.7.4...v0.8.0
 [0.7.4]: https://github.com/dokan-dev/dokany/compare/0.7.2...v0.7.4

Dokan.props

@@ -3,7 +3,7 @@
   <ImportGroup Label="PropertySheets" />
   <PropertyGroup Label="UserMacros">
     <DOKANAPIVersion>1</DOKANAPIVersion>
-    <DOKANVersion>1.0.1</DOKANVersion>
+    <DOKANVersion>1.0.2</DOKANVersion>
   </PropertyGroup>
   <PropertyGroup />
   <ItemDefinitionGroup />

appveyor.yml

@@ -71,7 +71,7 @@
 
           function updateCygwin($cygwinexe, $installFolder, $cacheFolder) {
             Write-Host "Update Cygwin: $cygwinexe"
-            Exec-External {& cmd /c $cygwinexe -gqnNdO -R $installFolder -s http://mirrors.kernel.org/sourceware/cygwin/ -l $cacheFolder -P cmake -P make -P gcc-core -P gcc-g++}
+            Exec-External {& cmd /c $cygwinexe -gqnNdO -R $installFolder -s http://mirrors.kernel.org/sourceware/cygwin/ -l $cacheFolder -P cmake -P make -P gcc-core -P gcc-g++ -P pkg-config}
             Write-Host "Update Cygwin: $cygwinexe " -NoNewLine
             Write-Host "[ OK ]" -ForegroundColor Green
           }
@@ -224,52 +224,30 @@
         $buildArgs = @(
         "/m",
         "/l:C:\Program Files\AppVeyor\BuildAgent\Appveyor.MSBuildLogger.dll",
-        "/p:Configuration=Win10 Debug",
+        "/p:Configuration=Win8.1 Release",
         "/p:Platform=$env:PLATFORM")
 
         & $buildCmd $buildArgs
-
-        installDokanCert
-
-        .\cert\dokan-sign.ps1
 
-        cp .\x64\Win10Debug\dokan1.sys C:\Windows\System32\drivers\
-        Exec-External {& .\x64\Debug\dokanctl.exe /i d}
-        Exec-External {& .\x64\Debug\dokanctl.exe /i n}
-        New-Item C:\TMP -type directory | Out-Null
-
-        $app = Start-Process -passthru .\x64\Debug\mirror.exe -ArgumentList "/r C:\TMP /l m"
-        Start-Sleep -s 5
-
-        Exec-External {git clone -q https://github.com/Liryna/fstools.git}
         $buildArgs = @(
-        ".\fstools\winfstest.sln",
         "/m",
         "/l:C:\Program Files\AppVeyor\BuildAgent\Appveyor.MSBuildLogger.dll",
         "/p:Configuration=Release",
         "/p:Platform=$env:PLATFORM")
-        Exec-External {& $buildCmd $buildArgs}
 
-        Exec-External {git clone -q https://github.com/Liryna/winfstest.git}
-        $buildArgs = @(
-        ".\winfstest\winfstest.sln",
-        "/m",
-        "/l:C:\Program Files\AppVeyor\BuildAgent\Appveyor.MSBuildLogger.dll",
-        "/p:Configuration=Debug",
-        "/p:Platform=$env:PLATFORM")
-        Exec-External {& $buildCmd $buildArgs}
+        & $buildCmd $buildArgs
+
+        installDokanCert
 
-        Write-Host "Start FSX Test" -ForegroundColor Green
-        Exec-External {& .\fstools\src\fsx\fsx.exe -N 5000 M:\test}
-        Write-Host "FSX Test finished" -ForegroundColor Green
+        .\cert\dokan-sign.ps1
+
+        cp .\x64\Win8.1Release\dokan1.sys C:\Windows\System32\drivers\
+        Exec-External {& .\x64\Release\dokanctl.exe /i d}
+        Exec-External {& .\x64\Release\dokanctl.exe /i n}
+
+        cd .\samples
+        .\mirror_test.ps1
 
-        Write-Host "Start WinFSTest" -ForegroundColor Green
-        Exec-External {& .\winfstest\TestSuite\run-winfstest.bat . M:\}
-        Write-Host "WinFSTest finished" -ForegroundColor Green
-
-        Start-Sleep -s 5
-        Stop-Process $app.Id
-        Start-Sleep -s 5
         Exec-External {& verifier /query}
       }
       Write-Host Build Finished !

documentations/Doxyfile

@@ -38,7 +38,7 @@ PROJECT_NAME           = Dokan
 # could be handy for archiving the generated documentation or if some version
 # control system is used.
 
-PROJECT_NUMBER         = 1.0.0
+PROJECT_NUMBER         = 1.0.2
 
 # Using the PROJECT_BRIEF tag one can provide an optional one line description
 # for a project that appears at the top of each page and should give viewer a

dokan/access.c

@@ -1,7 +1,7 @@
 /*
   Dokan : user-mode file system library for Windows
 
-  Copyright (C) 2015 - 2016 Adrien J. <[email protected]> and Maxime C. <[email protected]>
+  Copyright (C) 2015 - 2017 Adrien J. <[email protected]> and Maxime C. <[email protected]>
   Copyright (C) 2007 - 2011 Hiroki Asakawa <[email protected]>
 
   http://dokan-dev.github.io

dokan/cleanup.c

@@ -1,7 +1,7 @@
 /*
   Dokan : user-mode file system library for Windows
 
-  Copyright (C) 2015 - 2016 Adrien J. <[email protected]> and Maxime C. <[email protected]>
+  Copyright (C) 2015 - 2017 Adrien J. <[email protected]> and Maxime C. <[email protected]>
   Copyright (C) 2007 - 2011 Hiroki Asakawa <[email protected]>
 
   http://dokan-dev.github.io
@@ -49,5 +49,4 @@ VOID DispatchCleanup(HANDLE Handle, PEVENT_CONTEXT EventContext,
   SendEventInformation(Handle, eventInfo, sizeOfEventInfo, DokanInstance);
 
   free(eventInfo);
-  return;
 }

dokan/close.c

@@ -1,7 +1,7 @@
 /*
   Dokan : user-mode file system library for Windows
 
-  Copyright (C) 2015 - 2016 Adrien J. <[email protected]> and Maxime C. <[email protected]>
+  Copyright (C) 2015 - 2017 Adrien J. <[email protected]> and Maxime C. <[email protected]>
   Copyright (C) 2007 - 2011 Hiroki Asakawa <[email protected]>
 
   http://dokan-dev.github.io
@@ -55,6 +55,4 @@ VOID DispatchClose(HANDLE Handle, PEVENT_CONTEXT EventContext,
   }
   ReleaseDokanOpenInfo(eventInfo, DokanInstance);
   free(eventInfo);
-
-  return;
 }

dokan/create.c

@@ -1,7 +1,7 @@
 /*
   Dokan : user-mode file system library for Windows
 
-  Copyright (C) 2015 - 2016 Adrien J. <[email protected]> and Maxime C. <[email protected]>
+  Copyright (C) 2015 - 2017 Adrien J. <[email protected]> and Maxime C. <[email protected]>
   Copyright (C) 2007 - 2011 Hiroki Asakawa <[email protected]>
 
   http://dokan-dev.github.io
@@ -332,5 +332,7 @@ VOID DispatchCreate(HANDLE Handle, // This handle is not for a file. It is for
 
   SendEventInformation(Handle, &eventInfo, sizeof(EVENT_INFORMATION),
                        DokanInstance);
-  return;
+
+  if (eventInfo.Status != STATUS_SUCCESS)
+    free((PDOKAN_OPEN_INFO)(UINT_PTR)eventInfo.Context);
 }

dokan/directory.c

@@ -1,7 +1,7 @@
 /*
   Dokan : user-mode file system library for Windows
 
-  Copyright (C) 2015 - 2016 Adrien J. <[email protected]> and Maxime C. <[email protected]>
+  Copyright (C) 2015 - 2017 Adrien J. <[email protected]> and Maxime C. <[email protected]>
   Copyright (C) 2007 - 2011 Hiroki Asakawa <[email protected]>
 
   http://dokan-dev.github.io
@@ -441,8 +441,8 @@ VOID AddMissingCurrentAndParentFolder(PEVENT_CONTEXT EventContext,
       currentFolder = TRUE;
     if (wcscmp(find->FindData.cFileName, L"..") == 0)
       parentFolder = TRUE;
-	if (currentFolder == TRUE && parentFolder == TRUE)
-		return; // folders are already there
+    if (currentFolder == TRUE && parentFolder == TRUE)
+      return; // folders are already there
   }
 
   GetSystemTimeAsFileTime(&systime);
@@ -611,7 +611,6 @@ VOID DispatchDirectoryInformation(HANDLE Handle, PEVENT_CONTEXT EventContext,
   // send directory information to driver
   SendEventInformation(Handle, eventInfo, sizeOfEventInfo, DokanInstance);
   free(eventInfo);
-  return;
 }
 
 #define DOS_STAR (L'<')

dokan/dokan.c

@@ -1,7 +1,7 @@
 /*
   Dokan : user-mode file system library for Windows
 
-  Copyright (C) 2015 - 2016 Adrien J. <[email protected]> and Maxime C. <[email protected]>
+  Copyright (C) 2015 - 2017 Adrien J. <[email protected]> and Maxime C. <[email protected]>
   Copyright (C) 2007 - 2011 Hiroki Asakawa <[email protected]>
 
   http://dokan-dev.github.io
@@ -774,29 +774,36 @@ BOOL SendToDevice(LPCWSTR DeviceName, DWORD IoControlCode, PVOID InputBuffer,
 BOOL DOKANAPI DokanGetMountPointList(PDOKAN_CONTROL list, ULONG length,
                                      BOOL uncOnly, PULONG nbRead) {
   ULONG returnedLength = 0;
+  PDOKAN_CONTROL dokanControl =
+      malloc(DOKAN_MAX_INSTANCES * sizeof(*dokanControl));
+  if (dokanControl == NULL) {
+    return FALSE;
+  }
 
-  DOKAN_CONTROL dokanControl[DOKAN_MAX_INSTANCES];
-  ZeroMemory(dokanControl, sizeof(dokanControl));
+  ZeroMemory(dokanControl, DOKAN_MAX_INSTANCES * sizeof(*dokanControl));
   *nbRead = 0;
 
   if (SendToDevice(DOKAN_GLOBAL_DEVICE_NAME, IOCTL_EVENT_MOUNTPOINT_LIST, NULL,
-                   0, dokanControl, sizeof(dokanControl), &returnedLength)) {
+                   0, dokanControl, sizeof(*dokanControl), &returnedLength)) {
     for (int i = 0; i < DOKAN_MAX_INSTANCES; ++i) {
       if (wcscmp(dokanControl[i].DeviceName, L"") == 0) {
         break;
       }
       if (!uncOnly || wcscmp(dokanControl[i].UNCName, L"") != 0) {
-        if (length < ((*nbRead) + 1))
+        if (length < ((*nbRead) + 1)) {
+          free(dokanControl);
           return TRUE;
+        }
 
         CopyMemory(&list[*nbRead], &dokanControl[i], sizeof(DOKAN_CONTROL));
         (*nbRead)++;
       }
     }
-
+    free(dokanControl);
     return TRUE;
   }
 
+  free(dokanControl);
   return FALSE;
 }
 
@@ -829,6 +836,7 @@ BOOL WINAPI DllMain(HINSTANCE Instance, DWORD Reason, LPVOID Reserved) {
     LeaveCriticalSection(&g_InstanceCriticalSection);
     DeleteCriticalSection(&g_InstanceCriticalSection);
   } break;
+  default: break;
   }
   return TRUE;
 }

dokan/dokan.h

@@ -1,7 +1,7 @@
 /*
   Dokan : user-mode file system library for Windows
 
-  Copyright (C) 2015 - 2016 Adrien J. <[email protected]> and Maxime C. <[email protected]>
+  Copyright (C) 2015 - 2017 Adrien J. <[email protected]> and Maxime C. <[email protected]>
   Copyright (C) 2007 - 2011 Hiroki Asakawa <[email protected]>
 
   http://dokan-dev.github.io
@@ -202,6 +202,8 @@ typedef struct _DOKAN_OPERATIONS {
   * If the file is a directory, CreateFile is also called.
   * In this case, CreateFile should return \c STATUS_SUCCESS when that directory
   * can be opened and DOKAN_FILE_INFO.IsDirectory has to be set to \c TRUE.
+  * On the other hand, if DOKAN_FILE_INFO.IsDirectory is set to \c TRUE
+  * but the path target a file, you need to return \c STATUS_NOT_A_DIRECTORY.
   *
   * DOKAN_FILE_INFO.Context can be use to store Data (like \c HANDLE)
   * that can be retrieved in all other request related to the Context

dokan/dokan.rc

@@ -16,8 +16,8 @@
 //
 
 VS_VERSION_INFO VERSIONINFO
- FILEVERSION 1,0,1,0000
- PRODUCTVERSION 1,0,1,0000
+ FILEVERSION 1,0,2,1000
+ PRODUCTVERSION 1,0,2,1000
  FILEFLAGSMASK 0x3fL
 #ifdef _DEBUG
  FILEFLAGS 0x1L
@@ -34,12 +34,12 @@ BEGIN
         BEGIN
             VALUE "CompanyName", "Dokan Project"
             VALUE "FileDescription", "Dokan Library"
-            VALUE "FileVersion", "1.0.1.0000"
+            VALUE "FileVersion", "1.0.2.1000"
             VALUE "InternalName", "dokan.dll"
-            VALUE "LegalCopyright", "Copyright (C) 2016"
+            VALUE "LegalCopyright", "Copyright (C) 2017"
             VALUE "OriginalFilename", "dokan.dll"
             VALUE "ProductName", "Dokan"
-            VALUE "ProductVersion", "1.0.1.0000"
+            VALUE "ProductVersion", "1.0.2.1000"
         END
     END
     BLOCK "VarFileInfo"

dokan/dokanc.h

@@ -1,7 +1,7 @@
 /*
   Dokan : user-mode file system library for Windows
 
-  Copyright (C) 2015 - 2016 Adrien J. <[email protected]> and Maxime C. <[email protected]>
+  Copyright (C) 2015 - 2017 Adrien J. <[email protected]> and Maxime C. <[email protected]>
   Copyright (C) 2007 - 2011 Hiroki Asakawa <[email protected]>
 
   http://dokan-dev.github.io

dokan/dokani.h

@@ -1,7 +1,7 @@
 /*
   Dokan : user-mode file system library for Windows
 
-  Copyright (C) 2015 - 2016 Adrien J. <[email protected]> and Maxime C. <[email protected]>
+  Copyright (C) 2015 - 2017 Adrien J. <[email protected]> and Maxime C. <[email protected]>
   Copyright (C) 2007 - 2011 Hiroki Asakawa <[email protected]>
 
   http://dokan-dev.github.io

dokan/fileinfo.c

@@ -1,7 +1,7 @@
 /*
   Dokan : user-mode file system library for Windows
 
-  Copyright (C) 2015 - 2016 Adrien J. <[email protected]> and Maxime C. <[email protected]>
+  Copyright (C) 2015 - 2017 Adrien J. <[email protected]> and Maxime C. <[email protected]>
   Copyright (C) 2007 - 2011 Hiroki Asakawa <[email protected]>
 
   http://dokan-dev.github.io
@@ -564,5 +564,4 @@ VOID DispatchQueryInformation(HANDLE Handle, PEVENT_CONTEXT EventContext,
 
   SendEventInformation(Handle, eventInfo, sizeOfEventInfo, DokanInstance);
   free(eventInfo);
-  return;
 }