Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 msi #697

Merged
merged 35 commits into from
Sep 23, 2024
Merged

V2 msi #697

merged 35 commits into from
Sep 23, 2024

Conversation

Romanitho
Copy link
Owner

Proposed Changes

  • Review the code for MSI creation
  • Remove invisible.vbs
  • Use of conhost.exe instead
  • Minor changes

Resolves #465 #514 #496

Copy link
Contributor

github-actions bot commented Sep 13, 2024

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
⚠️ COPYPASTE jscpd yes 2 1.56s
⚠️ MARKDOWN markdownlint 1 0 4 0.8s
⚠️ MARKDOWN markdown-link-check 1 2 4.46s
✅ MARKDOWN markdown-table-formatter 1 0 0 0.25s
✅ POWERSHELL powershell 11 0 23.7s
✅ POWERSHELL powershell_formatter 11 0 11.52s
⚠️ REPOSITORY checkov yes 1 13.42s
⚠️ REPOSITORY devskim yes 2 1.54s
✅ REPOSITORY dustilock yes no 0.0s
✅ REPOSITORY gitleaks yes no 0.7s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 14.77s
✅ REPOSITORY kics yes no 1.79s
✅ REPOSITORY secretlint yes no 0.79s
✅ REPOSITORY syft yes no 0.4s
✅ REPOSITORY trivy yes no 5.89s
✅ REPOSITORY trivy-sbom yes no 0.97s
⚠️ REPOSITORY trufflehog yes 1 3.38s
⚠️ SPELL cspell 13 80 6.56s
❌ SPELL lychee 1 2 0.73s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

dependabot bot and others added 4 commits September 16, 2024 06:43
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 6.1.0 to 7.0.2.
- [Release notes](https://github.com/peter-evans/create-pull-request/releases)
- [Commits](peter-evans/create-pull-request@c5a7806...d121e62)

---
updated-dependencies:
- dependency-name: peter-evans/create-pull-request
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
…r-evans/create-pull-request-7.0.2

Bump peter-evans/create-pull-request from 6.1.0 to 7.0.2
@Romanitho Romanitho merged commit e9ddb67 into main Sep 23, 2024
1 check failed
@Romanitho Romanitho deleted the v2-MSI branch September 23, 2024 22:56
@KnifMelti
Copy link
Contributor

Fantastic work!!! ❤️❤️❤️❤️
Now you really need a break from coding 🦖

@Romanitho
Copy link
Owner Author

Thank you 😊

We need to keep this "v2" in beta to ensure there are no issues, of course.
We also need to check how it behaves on the ARM architecture.

I need to add that there are breaking changes, like the registry that moves to another location and other things (mainly for admin and detection methods, for instance).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: replace invisible.vbs with run-hidden
2 participants