Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gpo enhancement / reworked #418

Merged
merged 14 commits into from
Oct 12, 2023
Merged

Gpo enhancement / reworked #418

merged 14 commits into from
Oct 12, 2023

Conversation

Romanitho
Copy link
Owner

Proposed Changes

  • Full GPO rewrite
  • Dedicated Scheduled task
  • Generate and add ADMX in assets

Related Issues

#346

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
⚠️ COPYPASTE jscpd yes 9 2.15s
⚠️ MARKDOWN markdownlint 1 1 4 1.05s
✅ MARKDOWN markdown-link-check 1 0 9.17s
✅ MARKDOWN markdown-table-formatter 1 1 0 0.25s
✅ POWERSHELL powershell 6 0 14.33s
✅ POWERSHELL powershell_formatter 6 0 9.45s
⚠️ REPOSITORY checkov yes 1 9.8s
⚠️ REPOSITORY devskim yes 4 2.17s
✅ REPOSITORY dustilock yes no 0.01s
✅ REPOSITORY gitleaks yes no 0.75s
⚠️ REPOSITORY git_diff yes 1 0.01s
✅ REPOSITORY grype yes no 11.84s
✅ REPOSITORY kics yes no 14.29s
✅ REPOSITORY secretlint yes no 1.08s
✅ REPOSITORY syft yes no 0.22s
✅ REPOSITORY trivy yes no 3.86s
✅ REPOSITORY trivy-sbom yes no 0.84s
⚠️ REPOSITORY trufflehog yes 1 3.86s
⚠️ SPELL cspell 8 208 11.22s
✅ SPELL lychee 1 0 1.44s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@Romanitho Romanitho linked an issue Oct 11, 2023 that may be closed by this pull request
@Romanitho
Copy link
Owner Author

#256

@Romanitho Romanitho changed the title Gpo enhancement Gpo enhancement / reworked Oct 11, 2023
@Romanitho Romanitho merged commit 274ceec into main Oct 12, 2023
2 of 3 checks passed
@Romanitho Romanitho deleted the GPO-enhancement branch October 12, 2023 21:55
@KnifMelti
Copy link
Contributor

WAU! You really did it... 💕
...my big lump in the stomach is gone!
Really, really simplified and handleable!!!!!

FallingDownGIF

@Romanitho
Copy link
Owner Author

It was not that easy to have something that works as expected.
Will remain in pre version for now waiting for bug discovery 😅

@KnifMelti
Copy link
Contributor

I think I found 1... #421

@Romanitho
Copy link
Owner Author

I'll check that tomorrow morning 👌🏼
Thanks

@KnifMelti
Copy link
Contributor

This is.. ..Perfect! 👍🤪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: GPO overwrite all settings
2 participants