Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest winget #412

Merged
merged 8 commits into from
Oct 9, 2023
Merged

Latest winget #412

merged 8 commits into from
Oct 9, 2023

Conversation

KnifMelti
Copy link
Contributor

Proposed Changes

Now with the constant developing/releases of WinGet we need to update all the time...

Related Issues

Romanitho/Winget-Install#89

@KnifMelti KnifMelti temporarily deployed to megalinter October 8, 2023 09:42 — with GitHub Actions Inactive
@KnifMelti KnifMelti marked this pull request as draft October 8, 2023 20:04
@KnifMelti KnifMelti temporarily deployed to megalinter October 8, 2023 21:41 — with GitHub Actions Inactive
@KnifMelti KnifMelti marked this pull request as ready for review October 8, 2023 21:47
@KnifMelti KnifMelti marked this pull request as draft October 8, 2023 22:54
@KnifMelti KnifMelti marked this pull request as ready for review October 9, 2023 02:58
@KnifMelti KnifMelti temporarily deployed to megalinter October 9, 2023 02:59 — with GitHub Actions Inactive
@Romanitho
Copy link
Owner

Maybe we can use your Get-AvailableWinGetVersion function during install and post install tasks?

@KnifMelti
Copy link
Contributor Author

Maybe we can use your Get-AvailableWinGetVersion function during install and post install tasks?

Does that in Post alteady
$AvailableWinGetVersion = Get-AvailableWinGetVersion

@KnifMelti KnifMelti temporarily deployed to megalinter October 9, 2023 13:08 — with GitHub Actions Inactive
@KnifMelti KnifMelti temporarily deployed to megalinter October 9, 2023 13:19 — with GitHub Actions Inactive
@Romanitho
Copy link
Owner

👌🏼

@KnifMelti KnifMelti temporarily deployed to megalinter October 9, 2023 13:31 — with GitHub Actions Inactive
@KnifMelti KnifMelti temporarily deployed to megalinter October 9, 2023 13:55 — with GitHub Actions Inactive
@Romanitho Romanitho merged commit c478bd4 into Romanitho:main Oct 9, 2023
3 checks passed
@KnifMelti KnifMelti deleted the LatestWinget branch October 9, 2023 15:23
@Romanitho Romanitho linked an issue Oct 10, 2023 that may be closed by this pull request
Copy link
Owner

@Romanitho Romanitho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion, I guess :)


#Check if WinGet is installed, if not set version to dummy...
$ResolveWingetPath = Resolve-Path "$env:programfiles\WindowsApps\Microsoft.DesktopAppInstaller_*_*__8wekyb3d8bbwe\winget.exe" | Sort-Object { [version]($_.Path -replace '^[^\d]+_((\d+\.)*\d+)_.*', '$1') }
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a bug when running as admin (not from system). I would go for the function Get-WingetCmd. This way, it's better if it is installed from SCCM/Intune or installed by hand with admin rights.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand, but do as is best!

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Winget update
3 participants