Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnected GNN: Catalyst-Adsorbate separator #44

Open
wants to merge 134 commits into
base: main
Choose a base branch
from

Commits on Jun 12, 2023

  1. no idea what I changed

    AlvaroC-ML committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    42553e7 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. Configuration menu
    Copy the full SHA
    fe76d29 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    064699f View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Configuration menu
    Copy the full SHA
    e897615 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e29b571 View commit details
    Browse the repository at this point in the history
  3. Corrected some typos.

    AlvaroC-ML committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    83fa9a9 View commit details
    Browse the repository at this point in the history
  4. Deleted disconnected model, as now it is a feature on data transforms…

    …. Changed a config file to reflect this.
    AlvaroC-ML committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    afa0ae0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    fca863c View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. Configuration menu
    Copy the full SHA
    78e829e View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. Modified the is_disconnected flag to be a variable so it can be used …

    …in yaml files. Also modified some yaml experiment files.
    AlvaroC-ML committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    e91c007 View commit details
    Browse the repository at this point in the history
  2. fixed some typos

    AlvaroC-ML committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    0719a7f View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2023

  1. Configuration menu
    Copy the full SHA
    61887f3 View commit details
    Browse the repository at this point in the history
  2. Added flag for only using a subset of the dataset with a unique datap…

    …oint for every (catalyst, adsorbate, cell) tuple.
    AlvaroC-ML committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    cec7663 View commit details
    Browse the repository at this point in the history
  3. Added if statement in base trainer to use only the desired subset of …

    …dataset for training purposes
    AlvaroC-ML committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    a2e6b33 View commit details
    Browse the repository at this point in the history
  4. fixed some typos

    AlvaroC-ML committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    82c7c59 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. Fixed a bug when closing the dataset and modified config files to mak…

    …e them easier to replicate
    AlvaroC-ML committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    431a7c7 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2023

  1. Configuration menu
    Copy the full SHA
    ab814b5 View commit details
    Browse the repository at this point in the history
  2. Implemented: getting separate predictions for ads, cats. Their output…

    …s get concatenated, and then passed through a 2-layer MLP to return a single value. Testing still needed.
    AlvaroC-ML committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    540a485 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Configuration menu
    Copy the full SHA
    59928cf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1e6346f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    49cb00c View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Changed the name of disconnected model to dependent as to make psace …

    …for other types of disconnected models
    AlvaroC-ML committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    c9d3c84 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    34e232c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a997c04 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. Now that the new dataset is implemented, we correct so the dependent …

    …model doesn't use it, and we start writing the independent model.
    AlvaroC-ML committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    39fe297 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Configuration menu
    Copy the full SHA
    f2f89ef View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Configuration menu
    Copy the full SHA
    7854976 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6435dcc View commit details
    Browse the repository at this point in the history
  3. Fixed small typo

    AlvaroC-ML committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    6a5f3d8 View commit details
    Browse the repository at this point in the history
  4. fixing bug

    AlvaroC-ML committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    0985b83 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. Configuration menu
    Copy the full SHA
    50687f5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b5a2414 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. Configuration menu
    Copy the full SHA
    ef44257 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. Configuration menu
    Copy the full SHA
    a37986c View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Configuration menu
    Copy the full SHA
    fd26418 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    745351f View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Configuration menu
    Copy the full SHA
    3020a46 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c617918 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Added positional encoding to allow the model to distinguish between a…

    …dsorbate and catalysts inputs
    AlvaroC-ML committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    684327d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9c83bec View commit details
    Browse the repository at this point in the history
  3. Modified training files.

    AlvaroC-ML committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    31ec588 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. Configuration menu
    Copy the full SHA
    9a71546 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    acf2d8a View commit details
    Browse the repository at this point in the history
  3. Did good progress on the implementation of energy forward, modified b…

    …ase trainer to make it easier to implement models like tifaenet/indfaenet. Now you just have to add it to a list in the initialization method.
    AlvaroC-ML committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    5aead8a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    189f7ce View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2023

  1. Finished implementation of transformer interactions, and will redo tr…

    …aining on transformer combination to see if I can reduce the number of parameters
    AlvaroC-ML committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    e8af33f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dc7d717 View commit details
    Browse the repository at this point in the history
  3. Made transformer larger

    AlvaroC-ML committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    2d45a38 View commit details
    Browse the repository at this point in the history
  4. Readied an experiment

    AlvaroC-ML committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    f5883a7 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Configuration menu
    Copy the full SHA
    7a223ad View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Configuration menu
    Copy the full SHA
    e7cee7a View commit details
    Browse the repository at this point in the history
  2. Changed training file.

    AlvaroC-ML committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    181ee53 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. Configuration menu
    Copy the full SHA
    c0cec2a View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. Implemented attention tifaenet through sparse matrix. Now changing ba…

    …ckend implementation of tifaenet so it uses heterogeneous graphs
    AlvaroC-ML committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    1120d03 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Finished implementing heterogeneous graphs dataset. Most of the chang…

    …es are simple changes in syntax throughout the code as heterogeneous graphs do not have the same syntax as homogeneous graphs in pytorch geometric.
    AlvaroC-ML committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    95a415c View commit details
    Browse the repository at this point in the history
  2. Code worked fine. Implemented the requirement of specifying the versi…

    …on of GAT. Training yaml files ready for submission.
    AlvaroC-ML committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    98a049f View commit details
    Browse the repository at this point in the history
  3. fixed small typo

    AlvaroC-ML committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    6dc745b View commit details
    Browse the repository at this point in the history
  4. fixed a mistake in coding

    AlvaroC-ML committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    558d701 View commit details
    Browse the repository at this point in the history
  5. Forgot a set_trace

    AlvaroC-ML committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    8ccb813 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Configuration menu
    Copy the full SHA
    0ca9573 View commit details
    Browse the repository at this point in the history
  2. Small typo

    AlvaroC-ML committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    5e1485c View commit details
    Browse the repository at this point in the history
  3. Fixed another typo

    AlvaroC-ML committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    b7cfdf2 View commit details
    Browse the repository at this point in the history
  4. fixing some last mistakes

    AlvaroC-ML committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    a249d35 View commit details
    Browse the repository at this point in the history
  5. Forgot an ipdb set trace.

    AlvaroC-ML committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    eb3f71d View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. Configuration menu
    Copy the full SHA
    e2ab7ac View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. Configuration menu
    Copy the full SHA
    886e1c2 View commit details
    Browse the repository at this point in the history
  2. fixed typo

    AlvaroC-ML committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    2ae470b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    50f794d View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. Configuration menu
    Copy the full SHA
    9d19590 View commit details
    Browse the repository at this point in the history
  2. Deleted sparse matrix implementation, which never ran fast enough to …

    …even train in 15 hours.
    AlvaroC-ML committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    b5bdd3c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b614b71 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c606298 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    86d7079 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    00b4f9f View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2023

  1. Configuration menu
    Copy the full SHA
    6298539 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Configuration menu
    Copy the full SHA
    d1df105 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4b9d648 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    89c9f6d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c8444f6 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Configuration menu
    Copy the full SHA
    2c93b91 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Forgot to uncomment the task part. I also didn't use the is_disconnec…

    …ted flag correctly in the testing part
    AlvaroC-ML committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    4b161e1 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2023

  1. Configuration menu
    Copy the full SHA
    8b461ed View commit details
    Browse the repository at this point in the history
  2. modified a training file

    AlvaroC-ML committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    ce00cc9 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2023

  1. Configuration menu
    Copy the full SHA
    f92b8f5 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. Finished implementing aschnet and also made some modifications to the…

    … way in which residual connections happen
    AlvaroC-ML committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    e7c9d58 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    69f84d3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bb7713c View commit details
    Browse the repository at this point in the history
  4. fixed a config file

    AlvaroC-ML committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    f1b3335 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    fe398c6 View commit details
    Browse the repository at this point in the history
  6. modified afaenet slightly

    AlvaroC-ML committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    3e48f96 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. Configuration menu
    Copy the full SHA
    10d882f View commit details
    Browse the repository at this point in the history
  2. modified a config file

    AlvaroC-ML committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    cbfd545 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5289e1c View commit details
    Browse the repository at this point in the history
  4. implementing more

    AlvaroC-ML committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    ac60cdc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f64a3ff View commit details
    Browse the repository at this point in the history
  6. readied config files

    AlvaroC-ML committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    b03446d View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. Configuration menu
    Copy the full SHA
    a54ff2d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    936e5fe View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Configuration menu
    Copy the full SHA
    06cb33d View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. fixed a mistake in aschnet

    AlvaroC-ML committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    f68c49b View commit details
    Browse the repository at this point in the history
  2. config file editing

    AlvaroC-ML committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    fe10633 View commit details
    Browse the repository at this point in the history
  3. debugging gemnet

    AlvaroC-ML committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    218df21 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    73ee5a1 View commit details
    Browse the repository at this point in the history
  5. config mistake

    AlvaroC-ML committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    c56e117 View commit details
    Browse the repository at this point in the history
  6. tried to implement gemnet, didn't work. Now rerunning faenet with the…

    … more standard config files
    AlvaroC-ML committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    2242eec View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2023

  1. config file for dpp

    AlvaroC-ML committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    1bf534d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f9d4b03 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6ea3ed2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1520a0a View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2023

  1. removed an ipdb

    AlvaroC-ML committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    1f605df View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. good config file included

    AlvaroC-ML committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    76e55cb View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2023

  1. Configuration menu
    Copy the full SHA
    e6fe4d4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a3588f0 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. Configuration menu
    Copy the full SHA
    cb69712 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. Fixed config files

    AlvaroC-ML committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    a6e867d View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. Configuration menu
    Copy the full SHA
    d553ab0 View commit details
    Browse the repository at this point in the history
  2. add debug file

    AlexDuvalinho committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    7908f0b View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. Configuration menu
    Copy the full SHA
    122e0a8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3ce8099 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f7169dc View commit details
    Browse the repository at this point in the history
  4. ✨ (gfn): Import from #51

    vict0rsch committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    bca6df9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0795e1a View commit details
    Browse the repository at this point in the history
  6. ♻️ (all): Blackify

    vict0rsch committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    62a6b14 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. Merge pull request #52 from RolnickLab/prepare-disconnected

    Import changes to prepare for gfn
    vict0rsch authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    de422e7 View commit details
    Browse the repository at this point in the history
  2. import changes from #48

    vict0rsch committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    b4ba938 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2024

  1. Merge pull request #53 from RolnickLab/disconnected-per-ads-datasets

    Disconnected per adsorbate dataset: import changes from #48
    AlexDuvalinho authored Jan 6, 2024
    Configuration menu
    Copy the full SHA
    7420ab5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6445a5c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ca497e8 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. fix setup

    vict0rsch committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    3f025ac View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. fix adsorbates filtering

    vict0rsch committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    4bb9aac View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1494d91 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2024

  1. config update

    AlexDuvalinho committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    7c96385 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'disconnected_gnn' of https://github.com/RolnickLab/ocp

    …into disconnected_gnn
    AlexDuvalinho committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    5c526f7 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. add ocdata

    AlexDuvalinho committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    f2591b7 View commit details
    Browse the repository at this point in the history