Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrote Multi-World Calendar #1907

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

Julexar
Copy link
Contributor

@Julexar Julexar commented Feb 27, 2024

No description provided.

Copy link
Contributor

@matt-quests-for-tacos matt-quests-for-tacos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to cause breaking changes for games that use this script.

Why not make a new version 5.4 for this api script? Or make a new script with the new name?

@Julexar
Copy link
Contributor Author

Julexar commented Mar 7, 2024

This is going to cause breaking changes for games that use this script.

Why not make a new version 5.4 for this api script? Or make a new script with the new name?

  1. I completely revamped it, so 1.0 is more accurate - wouldn't it just use the latest version anyways?
  2. I don't think there's a better name for this Script

"$schema": "https://github.com/Roll20/roll20-api-scripts/master/_Example%20Script%20-%20Check%20for%20formatting%20details/script.schema.json",
"name": "Multi-World Calendar",
"script": "mwcal.js",
"version": "1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may cause issues, I am going to move forward approving this but in the future I recommend making this a new version, that is incrementally greater than the current version.

@matt-quests-for-tacos matt-quests-for-tacos merged commit 721a331 into Roll20:master Mar 19, 2024
1 check passed
@Julexar Julexar deleted the rewrite-mw-calendar branch March 20, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants