Fixed Change Weapon reselection #1787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DameryDad
commented
Jul 21, 2023
DameryDad
commented
- Fixed bug with reselecting a weapon from the weapon-in-hand list on the Change Weapon dialog
- Recoded insertAmmo() to use setAttkTableRow() ensuring consistent data parsing & weapon table construction.
- Made many more functions asynchronous to multi-thread.
- Added support for AD&D2e Char Sheet v4.17.
- Added AC rule '+inhand' meaning the item must be in-hand to have an effect on armour class (e.g. Defender Sword).
- Fixed issue with ru:3 reusable ammo-changing items.
- Fixed issue with calculating saving throw table for high levels.
* Recoded insertAmmo() to use setAttkTableRow() ensuring consistent data parsing & weapon table construction. * Made many more functions asynchronous to multi-thread. * Added support for AD&D2e Char Sheet v4.17. * Added AC rule '+inhand' meaning the item must be in-hand to have an effect on armour class (e.g. Defender Sword). * Fixed issue with ru:3 reusable ammo-changing items. * Fixed issue with calculating saving throw table for high levels.
* Fixed bug with reselecting a weapon from the weapon-in-hand list on the Change Weapon dialog
* If a 5e (or other D&D version) character was loaded or transmogrified, the system would crash on checking the sheet version. Fixed.
Alicekb
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.